Closed
Bug 713133
Opened 13 years ago
Closed 11 years ago
Make packager.pm missing file warnings fatal on Thunderbird
Categories
(Thunderbird :: Build Config, defect)
Thunderbird
Build Config
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 21.0
People
(Reporter: rain1, Assigned: standard8)
References
Details
Attachments
(1 file)
3.72 KB,
patch
|
mconley
:
review+
|
Details | Diff | Splinter Review |
To do this, we need to clean up mail/installer/package-manifest.in, then set MOZ_PKG_FATAL_WARNINGS = 1 before including packager.mk in mail/installer/Makefile.in.
Reporter | ||
Comment 1•13 years ago
|
||
So looking at the last successful trunk build, the files that are currently present in package-manifest but are missing are: All platforms: bin/libfreebl3.chk bin/libsoftokn3.chk bin/libsoftokn3.chk Mac only: Daily.app/Contents/Plug-Ins/ Windows only: bin/Microsoft.VC80.CRT.manifest etc (bug 712960, so not relevant) bin/components/components.manifest Linux only: bin/libmozutils.so I guess we need to find out why each of them's missing.
Assignee | ||
Comment 2•13 years ago
|
||
(In reply to Siddharth Agarwal [:sid0] from comment #1) > All platforms: > bin/libfreebl3.chk > bin/libsoftokn3.chk > bin/libsoftokn3.chk We still ship these, but looks like they got moved, see bug 683441. > Mac only: > Daily.app/Contents/Plug-Ins/ Not sure. > Windows only: > bin/Microsoft.VC80.CRT.manifest etc (bug 712960, so not relevant) Yep, should be fixed now. > bin/components/components.manifest I've actually got a feeling we do ship this and it is needed for omni.jar generation, but that could be interfaces.manifest I'm thinking about. > Linux only: > bin/libmozutils.so Maybe something to do with this: http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/mozapps/installer/packager.mk#89
Reporter | ||
Comment 3•13 years ago
|
||
(In reply to Mark Banner (:standard8) from comment #2) > (In reply to Siddharth Agarwal [:sid0] from comment #1) > > All platforms: > > bin/libfreebl3.chk > > bin/libsoftokn3.chk > > bin/libsoftokn3.chk > > We still ship these, but looks like they got moved, see bug 683441. > > > Mac only: > > Daily.app/Contents/Plug-Ins/ > > Not sure. Seems like detritus -- http://hg.mozilla.org/mozilla-central/diff/0bd17bd1cbaf/browser/installer/osx/packages-static#l1.17 > > > bin/components/components.manifest > > I've actually got a feeling we do ship this and it is needed for omni.jar > generation, but that could be interfaces.manifest I'm thinking about. Yeah, I'm not sure why this doesn't show up on Windows. > > > Linux only: > > bin/libmozutils.so > > Maybe something to do with this: > http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/mozapps/installer/ > packager.mk#89 Bug 677501 explains this (it's only a dynamic library in places where jemalloc used to be dynamic).
Assignee | ||
Comment 4•13 years ago
|
||
We don't need bug 694371 to fix this bug - afact all of the vc80 file warnings are now gone.
No longer depends on: 694371
Updated•12 years ago
|
Assignee | ||
Comment 5•11 years ago
|
||
Ok, I've not been able to get Mac working, so lets just do it for Windows & Linux for now (Bug 835309 will pick up Mac). Those platforms have been green on try server for this patch. Of the packaging changes: - mozglue is now included in packaging in the same manner as for Firefox - jetpack is a lib that never got shipped, or just shouldn't have been in there. - cloudFileAccounts.js is a module, not a component (modules have a modules/* inclusion) - dom_power.xpt is a spelling mistake of the components directory - chardet.xpt is long not-shipped on all platforms, and was in removed-files.in for all but Mac, but really should just be in there once.
Assignee | ||
Updated•11 years ago
|
Attachment #707028 -
Flags: review?(Pidgeot18) → review?(mconley)
Comment 6•11 years ago
|
||
Comment on attachment 707028 [details] [diff] [review] Fix some warnings and enable it Review of attachment 707028 [details] [diff] [review]: ----------------------------------------------------------------- Hey Mark, this mostly looks good - just one question - see below. ::: mail/installer/package-manifest.in @@ +76,4 @@ > #endif > #endif > @BINPATH@/@DLL_PREFIX@mozalloc@DLL_SUFFIX@ > +#ifdef MOZ_SHARED_MOZGLUE Why is soundtouch being removed?
Assignee | ||
Comment 7•11 years ago
|
||
(In reply to Mike Conley (:mconley) from comment #6) > Why is soundtouch being removed? It is now being linked statically as per bug 816576.
Comment 8•11 years ago
|
||
Comment on attachment 707028 [details] [diff] [review] Fix some warnings and enable it Ok, cool - I'm good with this then.
Attachment #707028 -
Flags: review?(mconley) → review+
Assignee | ||
Comment 9•11 years ago
|
||
I landed this today with a couple of follow-ups on to enable it on Mac and fix bustage on Windows debug: https://hg.mozilla.org/comm-central/rev/0317bb637a48 https://hg.mozilla.org/comm-central/rev/ca8526c33ec9 https://hg.mozilla.org/comm-central/rev/ee851cfee5b6
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 21.0
You need to log in
before you can comment on or make changes to this bug.
Description
•