Closed Bug 713457 Opened 13 years ago Closed 13 years ago

Linux theme fixes

Categories

(Thunderbird :: Theme, defect)

Product:
Thunderbird
Component:
Theme
Version:
12 Branch
Platform:
All
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird11 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 12.0
Tracking Flags:
Tracking Status
thunderbird11 --- fixed

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(2 files, 1 obsolete file)

Screenshot showing the menubar issue
102.50 KB, image/png
Details
Fix the two errors
577 bytes, patch
mconley
: review+
mconley
: ui-review+
standard8
: approval-comm-aurora+
Details | Diff | Splinter Review 
I found two small errors in Linux theme after landing of Bug 644169.

With Personas applied the menu bar has a half transparent background color.
Never functional selector in toolbar definition.
Attached patch Fix the two errors (obsolete) — — Splinter Review 
I think the menubar background is a remnant there the bar was planned below the tabs.

The mail-toolbox:not(-moz-lwtheme) is never working because of the missing colon before -moz-lwtheme. I removed this selector and not fixed it because I think it's planned to use the gradient with personas like in the other themes.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #584273 - Flags: ui-review?(bwinton)
Attachment #584273 - Flags: review?(bwinton)
This screenshot shows how the menubar looks with personas.
Comment on attachment 584273 [details] [diff] [review]
Fix the two errors

So, Mike Conley has been doing a bunch of work both in relation to tabs-on-top, and on Linux, and even better, he's not on vacation this week, so I strongly suggest you ask him for review and ui-review next.  ;)

And the only reason I'm giving this patch the r- and ui-r- is because you seem to have uploaded a PNG file, instead of a patch, so there's nothing for me to review.  ;)  Hopefully Mike will be more lenient.  :)

Thanks,
Blake.
Attachment #584273 - Flags: ui-review?(bwinton)
Attachment #584273 - Flags: ui-review-
Attachment #584273 - Flags: review?(bwinton)
Attachment #584273 - Flags: review-
Now the right patch.
Attachment #584273 - Attachment is obsolete: true
Attachment #584577 - Flags: review?(mconley)
Paenglab:

Hm - can I assume this also applies to EarlyBird as well?

-Mike
Comment on attachment 584577 [details] [diff] [review]
Fix the two errors

Code looks good to me.
Attachment #584577 - Flags: review?(mconley) → review+
Yes EarlyBird has the same code. This comes from the Tabs on top code.
Keywords: checkin-needed
Attachment #584577 - Flags: approval-comm-aurora?
Attachment #584577 - Flags: ui-review+
Checked in to comm-central as http://hg.mozilla.org/comm-central/rev/c55d07ab4294
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
tracking-thunderbird11: --- → ?
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 12.0
Attachment #584577 - Flags: approval-comm-aurora? → approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: