713519 - getCharsetAlias should throw for unknown character sets

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Asaf Romano (gone)]

throw Components.classes["@mozilla.org/charset-converter-manager;1"].getService(Components.interfaces.nsICharsetConverterManager).getCharsetAlias("no such thing");

Error: uncaught exception: no such thing

Comment 1

[Asaf Romano (gone)]

Attachment: patch

Comment 2

[Asaf Romano (gone)]

Comment on attachment 584321 [details] [diff] [review]
patch

Cancelling review request as I'm not sure that the properties files covers everything.

Comment 3

[Asaf Romano (gone)]

Comment on attachment 584321 [details] [diff] [review]
patch

Oh well, it actually does. Sorry for the spam

Comment 4

[Simon Montagu :smontagu]

Comment on attachment 584321 [details] [diff] [review]
patch

Review of attachment 584321 [details] [diff] [review]:
-----------------------------------------------------------------

::: intl/uconv/tests/unit/test_bug713519.js
@@ +15,5 @@
> +
> +  do_check_eq(svc.getCharsetTitle("windows-1255"), "Hebrew (Windows-1255)");
> +  try {
> +    svc.getCharsetTitle("no such thing");
> +    do_throw("Calling getCharsetAlias with invalid value should throw.");

Change the second error message to "getCharsetTitle".

Comment 5

[Asaf Romano (gone)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/d76bf407d5c1

Comment 6

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/d76bf407d5c1