713891 - Cursor placement is a few pixels off from where expected when clicking on characters in the editor

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Add-on Builder, defect, P2)

Description

[Daniel Buchner [:dbuc]]

If you click on characters in the editor, you will notice that the placement of the cursor is off in relation to where you clicked. This causes the cursor to be placed to the right (sometimes a character over) from where you would expect it to be. This may be due to padding we added on the editor elements or other such styles that were in place to fix editor layer placement issues in earlier versions of ACE. I would try removing all styles that are not generated by the editor from its layers and containers to see if it overlays the text and clickable layers accurately. If there is no change, it is likely an ACE bug and I will address it with them.

Comment 1

[Sean McArthur [:seanmonstar]]

fixed on master https://github.com/mozilla/FlightDeck/commit/39e034c3515d5c154bb0adb60910f97eb2587457

Comment 2

[Daniel Buchner [:dbuc]]

If your text extends horizontally past the content area of the editor, and you have more than a single screen's vertical amount of text in the editor, the scroll bar reappears and covers the last line of text just as before.

Comment 3

[Thomas Bertels]

Reopened bug 676239 as I guess that's what you intended.

And thanks for the fix, it's great now!