714148 - NullPointerException at org.mozilla.gecko.db.AndroidBrowserDB.updateFaviconForUrl

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Gian-Carlo Pascutto [:gcp]]

E/AndroidRuntime(15451): FATAL EXCEPTION: Thread-14
E/AndroidRuntime(15451): java.lang.NullPointerException
E/AndroidRuntime(15451): 	at org.mozilla.gecko.db.AndroidBrowserDB.updateFaviconForUrl(AndroidBrowserDB.java:273)
E/AndroidRuntime(15451): 	at org.mozilla.gecko.db.BrowserDB.updateFaviconForUrl(BrowserDB.java:140)
E/AndroidRuntime(15451): 	at org.mozilla.gecko.ProfileMigrator$PlacesTask.addFavicon(ProfileMigrator.java:276)
E/AndroidRuntime(15451): 	at org.mozilla.gecko.ProfileMigrator$PlacesTask.migrateFavicons(ProfileMigrator.java:302)
E/AndroidRuntime(15451): 	at org.mozilla.gecko.ProfileMigrator$PlacesTask.migratePlaces(ProfileMigrator.java:345)
E/AndroidRuntime(15451): 	at org.mozilla.gecko.ProfileMigrator$PlacesTask.run(ProfileMigrator.java:377)
E/AndroidRuntime(15451): 	at java.lang.Thread.run(Thread.java:1020)

Comment 1

[Gian-Carlo Pascutto [:gcp]]

BitmapDrawable image = (BitmapDrawable) Drawable.createFromStream(byteStream, "src");

Using the result of this is wrapped in a try/catch but it doesn't handle the NPE. Want to add some logging to see what image is failing anyway.

Comment 2

[Gian-Carlo Pascutto [:gcp]]

Attachment: Patch 1. Check for incomplete/undecodable images

If Android can't decode the stored favicon because the data is truncated or in a format it can't handle, just skip it.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 584879 [details] [diff] [review]
Patch 1. Check for incomplete/undecodable images

Simple fix, we should take for aurora

Comment 4

[Gian-Carlo Pascutto [:gcp]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/aaf31de64891

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/mozilla-central/rev/aaf31de64891

Comment 6

[Alex Keybl [:akeybl]]

Comment on attachment 584879 [details] [diff] [review]
Patch 1. Check for incomplete/undecodable images

[Triage Comment]
Mobile only - approving for Aurora.

Comment 7

[Gian-Carlo Pascutto [:gcp]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/579bcfe3d3ac