Closed
Bug 714162
Opened 13 years ago
Closed 13 years ago
Don't traverse certainly alive selections
Categories
(Core :: DOM: Selection, defect)
Tracking
()
RESOLVED
FIXED
mozilla12
People
(Reporter: smaug, Assigned: smaug)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
1.08 KB,
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
1.68 KB,
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
nsFrameSelection is kept alive by Presshell (until Presshell is deleted) and for text form controls nsTextEditorState/nsTextControlFrame. When presshell is going away mShell is set to null using DisconnectFromPresShell. So, as long a mShell is there, the nsFrameSelection object should be certainly alive and the whole traversing is just useless.
Attachment #584818 -
Flags: review?(matspal)
Comment 1•13 years ago
|
||
Yes, the above comment is correct. I'm not familiar with the cycle collector or what NS_SUCCESS_INTERRUPTED_TRAVERSE means though, so you should get someone else to review the actual code change.
Assignee | ||
Updated•13 years ago
|
Attachment #584818 -
Flags: review?(matspal) → review?(continuation)
Assignee | ||
Comment 2•13 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=685465da3f10
Comment 3•13 years ago
|
||
Comment on attachment 584818 [details] [diff] [review] patch Review of attachment 584818 [details] [diff] [review]: ----------------------------------------------------------------- Looks good. Death to death stars! r=me given mats's comment.
Attachment #584818 -
Flags: review?(continuation) → review+
Updated•13 years ago
|
Assignee | ||
Comment 4•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/0d684c34d1e4
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
Updated•13 years ago
|
Version: 10 Branch → Trunk
Assignee | ||
Comment 5•13 years ago
|
||
I started to worry about this a bit, so better be safe.
Attachment #585860 -
Flags: review?(continuation)
Comment 6•13 years ago
|
||
Comment on attachment 585860 [details] [diff] [review] Safer version Review of attachment 585860 [details] [diff] [review]: ----------------------------------------------------------------- The diff on top of the previous patch wasn't really necessary for a tiny patch. At some point, we should probably another CC macro for this pattern (if document is non-null and in the current generation, return interrupted traverse).
Attachment #585860 -
Flags: review?(continuation) → review+
Assignee | ||
Comment 7•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/57a33c9f08b1
You need to log in
before you can comment on or make changes to this bug.
Description
•