Closed
Bug 714178
Opened 13 years ago
Closed 13 years ago
Expose CPP from configure to the build system
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla12
People
(Reporter: khuey, Assigned: khuey)
References
Details
Attachments
(1 file)
1.05 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
I don't think mozilla-central needs this, but the InstantBird folks do, and it's easy enough to do.
Updated•13 years ago
|
Blocks: Instantbird
Assignee | ||
Comment 1•13 years ago
|
||
Attachment #584852 -
Flags: review?(ted.mielczarek)
Comment 2•13 years ago
|
||
Yes we do need this. I just tried this patch on our win32 slave and here what we found out : $(CPP) works well with gmake, it's an implicit variable replaced at use time by '$(CC) -E'. When I call 'make showbuild' on a gmake objdir, I have this line : '/path/to/python.exe -O /path/to/mozilla/build/cl.py cl -E' whie, using this patch, with pymake, I have the following value : 'cl -E -nologo'. Using this value should work in our test case, but I'm not sure the result is what is expected. I believe we should find a patch on pymake. I tried to add 'CPP': '$(CC) -E', in pymake/implicit.py but it seems that '$(CC)' is resolved at init time rather that at use time (CPP = ' -E' when doing a showbuild). Hope this helps a little...
Comment 3•13 years ago
|
||
Comment on attachment 584852 [details] [diff] [review] Patch Review of attachment 584852 [details] [diff] [review]: ----------------------------------------------------------------- The inconsistent spacing in this file drives me nuts, but it's not worth worrying about.
Attachment #584852 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Comment 4•13 years ago
|
||
http://hg.mozilla.org/projects/build-system/rev/c56d11e05feb
Comment 5•13 years ago
|
||
Is using 'cl -E -nologo' instead of '/path/to/python.exe -O /path/to/mozilla/build/cl.py cl -E' (as mentioned in comment 2) something that should worry us?
Assignee | ||
Comment 6•13 years ago
|
||
Probably not. cl.py is only used for dependency generation for future rebuilds.
Assignee | ||
Comment 7•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c56d11e05feb
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•