Closed
Bug 714256
Opened 13 years ago
Closed 13 years ago
Remove nsTransactionManager::Lock()/Unlock()
Categories
(Core :: DOM: Editor, defect)
Tracking
()
RESOLVED
FIXED
mozilla12
People
(Reporter: smaug, Assigned: ehsan.akhgari)
Details
Attachments
(1 file)
|
16.93 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•13 years ago
|
||
No editor consumer accesses this object from multiple threads. I'm not sure about places though...
|
Reporter | |
Comment 2•13 years ago
|
||
The object is cycle collectable, so it would crash immediately if used in non-main-thread.
|
||
Comment 3•13 years ago
|
||
(In reply to Ehsan Akhgari [:ehsan] from comment #1) > No editor consumer accesses this object from multiple threads. I'm not sure > about places though... Places only uses the transaction manager from js in the ui thread.
|
|
Assignee | |
Comment 4•13 years ago
|
||
Attachment #585058 -
Flags: review?(roc) → review+
|
||
Comment 5•13 years ago
|
||
Try run for 6355fe761f05 is complete.
Detailed breakdown of the results available here:
https://tbpl.mozilla.org/?tree=Try&rev=6355fe761f05
Results (out of 206 total builds):
exception: 1
success: 183
warnings: 22
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/eakhgari@mozilla.com-6355fe761f05
Timed out after 06 hours without completing.|
|
Assignee | |
Comment 6•13 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/a4a07b81ad67
Target Milestone: --- → mozilla12
|
||
Comment 7•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a4a07b81ad67
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•