714418 - Remove nsIXPCScriptable::DONT_SHARE_PROTOTYPE (and make all XPCWNProtos be shared)

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: patch

We appear to support singleton XPCWrappedNativeProtos, but I don't think this is ever used. I checked MXR and I added an assertion and got a green on try. So this should be safe.

May our invariants grow stronger each day!

I'd also like to get rid of these uppercase variable names. They're awful.

Comment 1

[Bobby Holley (:bholley)]

Comment on attachment 585110 [details] [diff] [review]
patch

Looks good!

This needs sr, I think. I'm guessing we don't need to rev the IDL here since it's just a constant, but blake would know for sure. Flagging him for sr.

Comment 2

[Bobby Holley (:bholley)]

(In reply to Bill McCloskey (:billm) from comment #0) 
> I'd also like to get rid of these uppercase variable names. They're awful.

I'd guess that they'd be going away with the new DOM bindings, so it's probably better to just wait. :-)

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

No, removing enums is binary compatible.

Comment 4

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1dc627b6158d

Comment 5

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/mozilla-central/rev/1dc627b6158d