714710 - LayerRenderer.checkFrameRateMonitorEnabled should use start() instead of run()

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/gfx/LayerRenderer.java#328

Calling .run() doesn't actually start the Thread, so we are hurting the main thread IO

We should be calling start() here

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

simple patch

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/03f3e1ebcd64

Comment 3

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/03f3e1ebcd64

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 585351 [details] [diff] [review]
patch

[Approval Request Comment]
Code cleanup. No risk

Small chance of a the startup improvement, but mainly for correctness.

Comment 5

[Alex Keybl [:akeybl]]

Comment on attachment 585351 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approving for Aurora given the possible perf improvement, otherwise this likely wouldn't meet the criteria for Aurora.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/11ed60b8dc20