714829 - Unused StringBuffer is created in GeckoApp.addEnvToIntent

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

Patch just removes the unused code in mobile/android and embedding/android

Comment 1

[Doug Turner (:dougt)]

Comment on attachment 585432 [details] [diff] [review]
patch

><

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5bbbb0127380

Comment 3

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/5bbbb0127380

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 585432 [details] [diff] [review]
patch

[Approval Request Comment]
Code cleanup. No risk

Comment 5

[Alex Keybl [:akeybl]]

Comment on attachment 585432 [details] [diff] [review]
patch

[Triage Comment]
Code cleanup of unused variables without user impact is typically outside the scope of Aurora.

Comment 6

[Brad Lassey [:blassey] (use needinfo?)]

Finkle, if you're not going to uplift this please mark the whiteboard not-fennec-11

Comment 7

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 585432 [details] [diff] [review]
patch

harmless patch and taking it prevents us from having to rebase other patches

Comment 8

[Brad Lassey [:blassey] (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-beta/rev/5e0e7eea8caf