714880 - Improve the error handling of print-manifest-dirs

Status: NEW

(Core :: Layout, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

Attachment: Improve the error handling of print-manifest-dirs

Currently if we have parsing problems we just run into type errors. This makes print-manifest-dirs describe the problem better.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Attachment: parse urls better

When we have HTTP, the paths that we have are urls and we should only use the path component instead of the whole url. This fixes the parsing of some of the reftests in image/test/reftest/encoders-lossless/reftest.list

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 585475 [details] [diff] [review]
Improve the error handling of print-manifest-dirs

Review of attachment 585475 [details] [diff] [review]:
-----------------------------------------------------------------

This feels like a messy way to handle the sitation. Instead, perhaps just set testURLs = None up before the if/else chain, and then you can do
if testURLs is None:
    <error>