71495 - Landings to necko cause PSM 2.0 to not work

Status: VERIFIED FIXED

(Core :: Networking: HTTP, defect)

Description

[Javier Delgadillo]

This is bug is for tracking PSM 2.0 inter-operability with necko.

The recent landings to necko have caused https to no longer work with PSM 2.0
and mozilla trunk builds.

SSL/IMAP still works.  From my debugging, a call to PSM 2.0's write method
returns PR_WOULD_BLOCK_ERROR then necko never tries to write again.

Comment 1

[Darin Fisher]

Strange that SSL/Imap works bug HTTPS does not... they both use sSocketTransport
right??

Comment 2

[Javier Delgadillo]

Forcing the handshake on the SSL connection causes everything to "just work".

Just talked to nelsonb and he told me there was no upside or downside to forcing
the handshake for all client connections withing PSM 2.0

Unless someone can think of a reason to not force the handshake on all
connections in PSM 2.0, then that may be our solutiong.

For the record, I forced the handshake in my build, and https and SSL/IMAP still
work.  But I haven't done any testing of SSL/SMTP since PSM 2.0 still chooses
the wrong cert for me.

Comment 3

[John G. Myers]

Forcing the handshake causes the thread to block until the handshake is done.

Comment 4

[Darin Fisher]

Yeah... I don't think you want to block the socket thread for this.  It might
simplify things for the socket transport, but responsiveness would suffer --
though I'm not sure if this "suffering" would be measureable.

Comment 5

[Darin Fisher]

Attachment: Fixes problem

Comment 6

[Darin Fisher]

Attachment: Fixes problem

Comment 7

[Darin Fisher]

Attachment: Fixes problem

Comment 8

[Darin Fisher]

I got a little trigger happy when submitting the attachment (patch repeated
three times!).  Anyways, this bug was regression from my patch for bug 66516.

Comment 9

[Brian Ryner (not reading)]

r=bryner

Comment 10

[Scott MacGregor]

sr=mscott

Comment 11

[Darin Fisher]

fix checked in.

Comment 12

[benc]

VERIFIED:

HTTPS seems to be working overall in Mozilla 0.9.

cc: security's' default qa contact in case this should not be verified.