715141 - Using keyboard to switch zoom level when viewing images directly

Status: RESOLVED WONTFIX

(Firefox :: General, enhancement)

Description

[nicolas m]

User Agent: Mozilla/5.0 (X11; Linux i686; rv:12.0a1) Gecko/20120103 Firefox/12.0a1
Build ID: 20120103031056

Steps to reproduce:

When an image is displayed directly in the browser and is larger than the view area, its size is adapted to the window. If you click on it, it becomes rendered in a 1:1 zoom level. If you click again, it comes back to the adapted zoom level.
This is impossible to do when navigating with the keyboard. Adding a shortcut (like the Spacebar) to switch between the two zoom levels could be useful.

Comment 1

[Justin Dolske [:Dolske]]

Seems reasonable. Good first bug?

Probably can't be space, though, since that's also used to scroll the page (and the page could be scrollable when viewed 1:1). At least, it would seem weird to do:

 * image loads, initially scaled to window
 * press space
 * image shown 1:1
 * press space
 ! image scrolls (eventually to bottom)
 * press space
 ! nothing happens (already at bottom)

Maybe Enter instead? Or change how Control +/- works?

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

I tested this out with the image located in the URL field of this bug.

Ctrl +/- already work to scale the image incrementally. If users would like a way to reach 1:1 scaling of the image, then I think we should add a modification to the normal Ctrl +/-, so maybe we could use shift-control +/-?

The other thing that this bug will have to do is to swap the cursor to use |cursor: -moz-zoom-out;| when the keyboard modifier is pressed.

The changes for this bug will probably occur in /content/html/document/src/ImageDocument.cpp.

Due to the lack of an XBL binding here, this is probably "good second bug" territory ;)

Comment 3

[Matthew Schranz [:mjschranz]]

Won't be able to do work on this one immediately as I'm working on some others but this one is definitely interesting to me. Going to take it for now.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Matthew: I've reassigned this bug to diogogmt since it sounds like they will be able to work on it sooner.

Comment 5

[Matthew Schranz [:mjschranz]]

Thats fine. I wasnt sure to take it in the beginning because it looked like diogo wanted it.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

After speaking with Gavin, we decided that this feature is too hard for users to discover and its presence will only add complexity to the codebase.