715190 - glEGLImageTargetTexture2DOES shows error 501 frequently

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

This is actually from other GL commands and not the one it is reporting. Should fix this up so at least it doesn't show bogus errors.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Clear existing GL errors before trying to check for a new one

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Clear existing GL errors before trying to check for a new one

Comment 3

[Chris Lord [:cwiiis]]

Comment on attachment 585798 [details] [diff] [review]
Clear existing GL errors before trying to check for a new one

Review of attachment 585798 [details] [diff] [review]:
-----------------------------------------------------------------

Fine by me - I wonder if we want to have wrappers for GL commands though (I think gfx does this?) that will read and report errors automatically for debug builds, or something along those lines... But this can be addressed in a future patch.

Optionally, it'd be cool to have comments above the while loops, at least in the Java file, explaining why it's being done - something like "GL errors may have been encountered elsewhere, but we're only interested in those that occur here"

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

I think there might be a debug EGLContext in Android that basically wraps everything and checks for errors. Maybe we should just add support for using that and ditch the specific error checking.

In the mean time I'll add the comment and check this in.

Comment 5

[James Willcox (:snorp) ([e-mail]) (he/him)]

Pushed to mozilla-inbound:

http://hg.mozilla.org/integration/mozilla-inbound/rev/4d652a824f11

Comment 6

[James Willcox (:snorp) ([e-mail]) (he/him)]

Landed on mozilla-central:

https://hg.mozilla.org/mozilla-central/rev/4d652a824f11

Comment 7

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 585798 [details] [diff] [review]
Clear existing GL errors before trying to check for a new one

[Triage Comment]

Comment 8

[Brad Lassey [:blassey] (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d53dfe552b54