Closed Bug 715275 Opened 13 years ago Closed 12 years ago

No favicon / default favicon image is very fuzzy

Categories

(Firefox for Android Graveyard :: General, defect, P4)

Product:
Firefox for Android Graveyard
Component:
General
Version:
11 Branch
Platform:
ARM
Android
Type:
defect

Tracking

(firefox11 fixed, firefox12 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 12
Tracking Flags:
Tracking Status
firefox11 --- fixed
firefox12 --- verified

People

(Reporter: padamczyk, Assigned: mbrubeck)

Details

Attachments

(3 files)

Fuzzy icon example
159.38 KB, image/png
Details
Update default favicons (5 sizes)
10.57 KB, application/zip
Details
patch
11.16 KB, patch
sriram
: review+
akeybl
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Attached image Fuzzy icon example — 
Higher quality / multiple image sizes of the no favicon / default favicon are needed.
Assignee: nobody → padamczyk
Priority: -- → P4
Attached are the production assets.
Assignee: padamczyk → nobody
Assignee: nobody → mbrubeck
Attached patch patch — — Splinter Review 
Sorry for taking a while to get to this, Patryk.  This bug adds new default favicon images at the following sizes as used in the awesomescreen:

MDPI:  32px
HDPI:  48px
XHDPI: 64px

The favicon in the URL bar is drawn at a smaller size (21.33dp, which maps to the pixel sizes below).  Currently it is just a scaled-down version of the default favicon.  If you'd like to provide a separate image for the smaller URL bar icon, it should be at the following sizes:

MDPI:  21px
HDPI:  32px (we already have an icon available at this size)
XHDPI: 43px (I think - can someone with an XHDPI device test this?)
Attachment #591603 - Flags: review?(sriram)
Comment on attachment 591603 [details] [diff] [review]
patch

Review of attachment 591603 [details] [diff] [review]:
-----------------------------------------------------------------

The patch looks fine to me.
I haven't tested it yet though.
Attachment #591603 - Flags: review?(sriram) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/8113ce367f8f
Status: NEW → ASSIGNED
status-firefox11: --- → affected
status-firefox12: --- → fixed
Target Milestone: --- → Firefox 12
Comment on attachment 591603 [details] [diff] [review]
patch

[Approval Request Comment]
Trivial Android-only change to tweak some image files.  Fixes some fuzzily-scaled images in the UI.
Attachment #591603 - Flags: approval-mozilla-aurora?
Comment on attachment 591603 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Aurora.
Attachment #591603 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/mozilla-central/rev/8113ce367f8f
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
This. Is. Lovely.

Verified Fixed on M-C
Samsung Galaxy Nexus (Android 4.0.3)
20120126031113
http://hg.mozilla.org/mozilla-central/rev/402b394b6623

Aurora nom?
Status: RESOLVED → VERIFIED
status-firefox12: fixed → verified
OS: Mac OS X → Android
Hardware: x86 → ARM
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: