Closed Bug 715301 Opened 13 years ago Closed 13 years ago

The Open Web Apps addon disables XUL cache!!!

Categories

(Web Apps :: Extension, defect)

Product:
Web Apps
Component:
Extension
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: ehsan.akhgari, Unassigned)

Details

$ grep -rni disable_xul_cache .
./extensions/openwebapps@mozillalabs.com/resources/openwebapps/data/native-install/XUL/defaults/preferences/prefs.js:10:pref("nglayout.debug.disable_xul_cache", true);

There is no reason why this add-on should do this at all.  This makes Firefox use lots of memory and causes CC pauses.
...and makes browser startup slower and what not.
Worse yet, it's not a supported configuration.  Some things are just broken with this cache disabled, not just slower...
This is worse than I realized.  Here's the complete prefs.js file:

  1 pref("browser.chromeURL","chrome://webapp/content/window.xul");
  2 pref("browser.hiddenWindowChromeURL", "chrome://webapp/content/main.xul");
  3 pref("toolkit.defaultChromeURI", "chrome://webapp/content/window.xul");
  4 pref("toolkit.singletonWindowType", true);
  5 pref("extensions.logging.enabled", "true");
  6 pref("dom.report_all_js_exceptions", "true");
  7 pref("browser.dom.window.dump.enabled", true);
  8 pref("javascript.options.showInConsole", true);
  9 pref("javascript.options.strict", true);
 10 pref("nglayout.debug.disable_xul_cache", true);
 11 pref("nglayout.debug.disable_xul_fastload", true);

None of this should be needed at all.
It's important to note that these prefs are not applied to the addon or firefox.  The file is stored in the addon and copied into each native app bundle that is created.
These prefs only affect the firefox that is launched (in xulrunner mode) when you launch a native webapp.

This does not mean that some of them are probably unnecessary and should not have been left in.  Likely #10 and #11 should be removed.  Perhaps all but #1-4 should be removed.  I am investigating.
I don't see the XUL cache disabled when I install the runtime ...
Kyle I think you have to install an app natively, and then launch the app. 

The app that is then launched in a chromeless window will have xul cache disabled.
(In reply to dclarke@mozilla.com from comment #6)
> Kyle I think you have to install an app natively, and then launch the app. 
> 
> The app that is then launched in a chromeless window will have xul cache
> disabled.

If I close the app and startup the Firefox again is the XUL cache disabled for Firefox?
As dclark said, this prefs.js file *is not used by the addon in firefox*.  OpenWebApps creates xulrunner style stub applications using the firefox binary to load applications.  The prefs.js file referenced is used as a part of that.  

Otherwise, yes, that prefs.js file needs to be cleaned up.  Most of those settings are debug/develop settings. I'm not sure if the first item is necessary (I think it is), items 2,3,4 are necessary, the rest could be commented out for release.
Yes, that is my conclusion as well, and I'll take out the questionable ones today.   I'm going to leave 1-4 in, as I believe we need those to function properly with the rest of our native app skeleton.
Hmm, this is werid.  When I uninstalled the OWA add-on, my xul cache pref was set to false...
These prefs were necessary at the time of development to debug native apps generated by the add-on. We could comment these out for a release version.
commented out unnecessary prefs.  commit 04c147246c48877afe0d8f140d092641f0781f81
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Will this affect the mozilla-central implementation of native install? Not sure if it will or not.
You need to log in before you can comment on or make changes to this bug.