715408 - mochitests will hang if previous test run didn't clean up

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

STR:
1) run mochitests
2) ctrl+C
3) run mochitests

ER:
mochitests run

AR:
mochitests hang

Comment 1

[Geoff Brown [:gbrown]]

blassey is talking about mochitest-remote here. We found that manually deleting the profile from the device got things working again.

runtests.py::runTests() calls runtestsremote.py::cleanup() which deletes the remote profile. But the cleanup() call is at the end of the test run. When ctrl+C is used to break out of a run, presumably this is not called. 

Maybe the profile directory could be deleted on startup instead of, or in addition to, on shutdown? Or we could handle ctrl+C better perhaps....

Comment 2

[Geoff Brown [:gbrown]]

Attachment: patch to delete remote profile before pushing a new one

I am hopeful this very simple change will work, but haven't tested it yet.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

this seems pretty harmless and a good safe guard.

Comment 4

[Geoff Brown [:gbrown]]

Works fine for me locally. 

Also pushed to try:

https://tbpl.mozilla.org/?tree=Try&rev=f9cbab998894

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 585971 [details] [diff] [review]
patch to delete remote profile before pushing a new one

Review of attachment 585971 [details] [diff] [review]:
-----------------------------------------------------------------

looks very harmless, try server will be my best friend here.

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fa8c8e768e9f

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/fa8c8e768e9f