Closed
Bug 715488
Opened 13 years ago
Closed 12 years ago
Mostly-Permanent orange: TEST-UNEXPECTED-FAIL | test-attachment.js | test-attachment.js::test_attachments_compose_menu
Categories
(Thunderbird :: Testing Infrastructure, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 12.0
People
(Reporter: mconley, Assigned: mconley)
References
Details
(Keywords: intermittent-failure)
Attachments
(1 file, 6 obsolete files)
3.96 KB,
patch
|
standard8
:
review+
|
Details | Diff | Splinter Review |
So I re-enabled the attachment tests in the Mozmill test suite (bug 711085), and now we're seeing a permanent orange on Linux. The error message for the test is: Test Failure: attachmentBucket is not focused!: 'Remove Attachment' != 'Delete'. TEST-UNEXPECTED-FAIL | /buildbot/comm-central-linux-opt-unittest-mozmill/build/mozmill/attachment/test-attachment.js | test-attachment.js::test_attachments_compose_menu
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → mconley
Whiteboard: [tb-orange]
Assignee | ||
Comment 1•13 years ago
|
||
I've seen cases on both Linux 32 and 64 bit where the tests all pass. They're rare, but they exist.
Summary: Permanent orange: TEST-UNEXPECTED-FAIL | test-attachment.js | test-attachment.js::test_attachments_compose_menu → Mostly-Permanent orange: TEST-UNEXPECTED-FAIL | test-attachment.js | test-attachment.js::test_attachments_compose_menu
Assignee | ||
Comment 2•13 years ago
|
||
I *think* the test is failing because we're not giving the event loop enough time to update the label of the cmd_delete element. Try builds coming in here: http://build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTry&rev=84e3e2c94122
Assignee | ||
Comment 3•13 years ago
|
||
First patch didn't fix it. Here's another shot. http://build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTry&rev=9cea77f68d48
Attachment #586075 -
Attachment is obsolete: true
Assignee | ||
Comment 4•13 years ago
|
||
Hrm, this is starting to get a little frustrating. Trying a third time, and falling back to default error messages for assert_equals for diagnostics. http://build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTry&rev=fb656152eb97
Attachment #586145 -
Attachment is obsolete: true
Assignee | ||
Comment 5•13 years ago
|
||
http://build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTry&rev=6a4eac81a069
Attachment #586187 -
Attachment is obsolete: true
Assignee | ||
Comment 6•12 years ago
|
||
I've reduced this to a focus issue that seems to be unique to Linux. It seems that focus events are not sent to elements when the parent window is not focused. I can reliably reproduce this on my machine. I think I've found a workaround. Patch forthcoming.
Assignee | ||
Comment 7•12 years ago
|
||
http://build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTry&rev=c59c319dedb4
Attachment #586434 -
Attachment is obsolete: true
Assignee | ||
Comment 8•12 years ago
|
||
Attachment #586998 -
Attachment is obsolete: true
Assignee | ||
Comment 9•12 years ago
|
||
Attachment #587302 -
Attachment is obsolete: true
Assignee | ||
Updated•12 years ago
|
Attachment #587310 -
Attachment is patch: true
Assignee | ||
Comment 10•12 years ago
|
||
Comment on attachment 587310 [details] [diff] [review] Patch v9 Hey Jim, I know you're swamped, but my patch is here is relatively small. Let me know if I should redirect the review request. Tested locally on OSX, Windows and Linux - all passing, even when the parent window is not focused. -Mike
Attachment #587310 -
Flags: review?(squibblyflabbetydoo)
Assignee | ||
Updated•12 years ago
|
Attachment #587310 -
Flags: review?(squibblyflabbetydoo) → review?(mbanner)
Updated•12 years ago
|
Attachment #587310 -
Flags: review?(mbanner) → review+
Assignee | ||
Comment 11•12 years ago
|
||
Committed to comm-central as http://hg.mozilla.org/comm-central/rev/7c894b95efe4
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Target Milestone: --- → Thunderbird 12.0
Updated•12 years ago
|
Keywords: intermittent-failure
Updated•12 years ago
|
Whiteboard: [tb-orange]
You need to log in
before you can comment on or make changes to this bug.
Description
•