715488 - Mostly-Permanent orange: TEST-UNEXPECTED-FAIL | test-attachment.js | test-attachment.js::test_attachments_compose_menu

Status: RESOLVED FIXED

(Thunderbird :: Testing Infrastructure, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

So I re-enabled the attachment tests in the Mozmill test suite (bug 711085), and now we're seeing a permanent orange on Linux.

The error message for the test is:

Test Failure: attachmentBucket is not focused!: 'Remove Attachment' != 'Delete'.
TEST-UNEXPECTED-FAIL | /buildbot/comm-central-linux-opt-unittest-mozmill/build/mozmill/attachment/test-attachment.js | test-attachment.js::test_attachments_compose_menu

Comment 1

[Mike Conley (:mconley) (:⚙️)]

I've seen cases on both Linux 32 and 64 bit where the tests all pass.  They're rare, but they exist.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1

I *think* the test is failing because we're not giving the event loop enough time to update the label of the cmd_delete element.

Try builds coming in here:  http://build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTry&rev=84e3e2c94122

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Second shot

First patch didn't fix it.  Here's another shot.

http://build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTry&rev=9cea77f68d48

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: Third go at it.

Hrm, this is starting to get a little frustrating.  Trying a third time, and falling back to default error messages for assert_equals for diagnostics.

http://build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTry&rev=fb656152eb97

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Attachment: Fifth shot at it.

http://build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTry&rev=6a4eac81a069

Comment 6

[Mike Conley (:mconley) (:⚙️)]

I've reduced this to a focus issue that seems to be unique to Linux.  It seems that focus events are not sent to elements when the parent window is not focused.  I can reliably reproduce this on my machine.

I think I've found a workaround.  Patch forthcoming.

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v7

http://build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTry&rev=c59c319dedb4

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v8

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v9

Comment 10

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 587310 [details] [diff] [review]
Patch v9

Hey Jim,

I know you're swamped, but my patch is here is relatively small.  Let me know if I should redirect the review request.

Tested locally on OSX, Windows and Linux - all passing, even when the parent window is not focused.

-Mike

Comment 11

[Mike Conley (:mconley) (:⚙️)]

Committed to comm-central as http://hg.mozilla.org/comm-central/rev/7c894b95efe4