Closed Bug 715718 Opened 13 years ago Closed 12 years ago

[Skia] Unitialized variable 'margin' in SkDraw.cpp

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla12

People

(Reporter: mattwoodrow, Assigned: mattwoodrow)

Details

Attachments

(1 file)

Initialize the margin
2.11 KB, patch
gw280
: review+
Details | Diff | Splinter Review 

        Attachment #586268 -
        Flags: review?(jmuizelaar)

        Attachment #586268 -
        Flags: review?(jmuizelaar) → review?(gwright)

    
    

    
  
Looks good to me, but this should really be submitted upstream.

    
    

    
  
"unitialized-margin.patch" = typo. Should be uninitialized?

    
    

    
  
(In reply to George Wright from comment #2)
> Looks good to me, but this should really be submitted upstream.

George, can you take care of upstreaming this?

    
    

    
  
Yep, I'll get on that tomorrow.

        Attachment #586268 -
        Flags: review?(gwright) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/8763e1f49736
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: