715730 - Flash app restarts after clicking a selection when click to play is turned on

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: logcat.txt

1. go to menu -> more -> settings -> enable plugins -> Click to play
2. hit the back button and go to : https://settings.adobe.com
3. click on where it states "Tap here to activate plugins"
4. select Local Storage

Expected: flash will continue on with the app
Actual: flash app restarts

Note:
1. Samsung Nexus S, 2.3.1, flash 11, 20120105 build
2. also the flash plugin will continue to the next screen if yes was selected for the enable plugins option.

Comment 1

[:Margaret Leibovic]

This feels like a problem with the flash settings app. Possibly a dupe of bug 694546?

Comment 2

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

It's talking about the same portion, but I don't believe it's the same bug.  In the bug 694546 it's stating that it doesn't work at all.  I believe that it does work, but not when "Click to play" is enabled.

Comment 3

[:Margaret Leibovic]

With click to play enabled, I can tap to activate the plugin, but I run into problems when I try to select local storage like you say in comment 0. Does the app work correctly if you just have enable plugins set to "yes"?

Comment 4

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Yes, the app seems to work correctly if I just enable the plugins to yes and then restart fennec.

Comment 5

[:Margaret Leibovic]

Okay, I'm seeing the same thing. I just discovered if I hit the back button after going to the busted local storage page, then click on local storage again it works. Maybe there's a problem with the order in which we're loading the plugins on the page?

Comment 6

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Oh interesting.  Is there a way to test order of load easier?

Comment 7

[:Margaret Leibovic]

(In reply to Naoki Hirata :nhirata from comment #6)
> Oh interesting.  Is there a way to test order of load easier?

Actually, I think this problem is caused by the same root issue that's causing bug 713080 - we're re-loading all the plugins when the plugin objects are tapped, even after they're loaded. I'm working on a patch now that will hopefully fix both these bugs.

Comment 8

[:Margaret Leibovic]

Attachment: patch

We were reloading the plugins every time the plugin object received a click event. Since we're playing all plugins when one is clicked, it's kind of tricky to remove the click event listeners, so I decided to just clear _pluginsToPlay and check its length when playAllPlugins gets called.

I also decided to get rid of the addPluginClickCallback I mostly stole from desktop, since we don't need that generic helper function, and I just replaced it with a normal click listener.

I think this will fix bug 713080 and bug 694546 as well. (I was hoping it would also fix bug 715740, but that doesn't seem to be the case.)

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 586506 [details] [diff] [review]
patch

Test switching between tabs with Flash to make sure we don't lose plugin info

Comment 10

[:Margaret Leibovic]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5971546ca35e

Comment 12

[:Margaret Leibovic]

This never got marked as fixed, but it made its way into mozilla-central:

https://hg.mozilla.org/mozilla-central/rev/5971546ca35e

Comment 13

[:Margaret Leibovic]

Comment on attachment 586506 [details] [diff] [review]
patch

[Approval Request Comment]
User impact if declined: interactive flash objects (like embedded youtube videos) won't work
Testing completed (on m-c, etc.): baked on m-c for a few days

Comment 14

[Alex Keybl [:akeybl]]

Comment on attachment 586506 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Aurora.

Comment 15

[:Margaret Leibovic]

https://hg.mozilla.org/releases/mozilla-aurora/rev/6470d94a3cac

Comment 16

[Cristian Nicolae (:xti)]

Verified fixed on:

Mozilla/5.0 (Android;Linux armv7l;rv:11.0a2)Gecko/20120130
Firefox/11.0a2 Fennec/11.0a2
Device: Samsung Galaxy S
OS: Android 2.2

Mozilla/5.0 (Android;Linux armv7l;rv:12.0a1)Gecko/20120130
Firefox/12.0a1 Fennec/12.0a1
Device: Samsung Galaxy S
OS: Android 2.2