Closed
Bug 715783
Opened 13 years ago
Closed 13 years ago
delay load for comdlg32 and winspool
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla12
People
(Reporter: m_kato, Assigned: m_kato)
Details
(Whiteboard: [inbound])
Attachments
(1 file)
|
529 bytes,
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
Both should be delay loaded dll. Becauses comdlg32 is for common dialog such as file open dialog and winspool is for printing.
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #586338 -
Flags: review?(khuey)
Comment on attachment 586338 [details] [diff] [review] fix Review of attachment 586338 [details] [diff] [review]: ----------------------------------------------------------------- r=me if you verify that with this patch we start up without loading these DLLs.
Attachment #586338 -
Flags: review?(khuey) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #2) > Comment on attachment 586338 [details] [diff] [review] > fix > > Review of attachment 586338 [details] [diff] [review]: > ----------------------------------------------------------------- > > r=me if you verify that with this patch we start up without loading these > DLLs. I tested on Win7. Both aren't loaded at startup by this fix.
|
|
Assignee | |
Comment 4•13 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/167afff96b0d
Whiteboard: [inbound]
|
||
Comment 5•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/167afff96b0d
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•