Closed
Bug 715791
Opened 13 years ago
Closed 13 years ago
Preprocessor.py doesn't preserve line numbers when preprocessing Java
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla12
People
(Reporter: kats, Assigned: kats)
Details
Attachments
(1 file, 1 obsolete file)
|
1.98 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
This means that java stack traces from Fennec on android are often off by a line, which is mildly annoying. Simple patch updates a regex so java files are treated like js files and have extra padding inserted to make line numbers line up. Pushed patch to try at https://tbpl.mozilla.org/?tree=Try&rev=3fdb9406cf51 to verify it doesn't break any builds.
Attachment #586337 -
Flags: review?(ted.mielczarek)
|
Assignee | |
Comment 1•13 years ago
|
||
Apparently I need to make the same change to js/src/config/Preprocessor.py. New try push at https://tbpl.mozilla.org/?tree=Try&rev=92c4e6163b89 (and sorry for the bugspam).
Attachment #586337 -
Attachment is obsolete: true
Attachment #586337 -
Flags: review?(ted.mielczarek)
Attachment #586340 -
Flags: review?(ted.mielczarek)
|
||
Updated•13 years ago
|
Attachment #586340 -
Flags: review?(ted.mielczarek) → review+
|
|
Assignee | |
Comment 2•13 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/4796cf23c294
|
||
Comment 3•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4796cf23c294
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•