Closed
Bug 715872
Opened 13 years ago
Closed 13 years ago
Change the order of -framework options when linking XUL so that it works on 10.6 -> 10.5 builds
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla12
People
(Reporter: espindola, Assigned: espindola)
References
Details
Attachments
(1 file)
No description provided.
Assignee | ||
Comment 1•13 years ago
|
||
On the 10.6 SDK and newer, the symbol _SCDynamicStoreCreate is visible in multiple freameworks: $ nm SystemConfiguration | grep -w _SCDynamicStoreCreate 0000000000002be7 T _SCDynamicStoreCreate $ nm IOKit | grep -w _SCDynamicStoreCreate$ 00000000000579cc S $ld$hide$os10.7$_SCDynamicStoreCreate 000000000001ed66 T _SCDynamicStoreCreate This is not a problem when the linker is run with a deployment target of 10.6, because it does the right thing and uses the symbol from SystemConfiguration. It is also not a problem when using the 10.5 SDK, since _SCDynamicStoreCreate is only visible in SystemConfiguration in there. The problem is when using the 10.6 SDK and a deployment target of 10.5. The resulting binary will use _SCDynamicStoreCreate from what is first on the command line. The first framework with _SCDynamicStoreCreate in the XUL link is IOKit, so XUL will find that symbol at runtime only when running on 10.6. To fix this, we just have to make sure that "-framework SystemConfiguration" comes before "-framework IOKit". That is what this patch does. https://tbpl.mozilla.org/?tree=Try&rev=bfe15ae3738c
Assignee: nobody → respindola
Status: NEW → ASSIGNED
Attachment #586403 -
Flags: review?(ted.mielczarek)
Updated•13 years ago
|
Attachment #586403 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Comment 2•13 years ago
|
||
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=25fe3fddc59e
Comment 3•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/25fe3fddc59e
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•