715922 - pop3 move mail filters with quarantining turned off or download size limit get the resulting message size too big by two bytes

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[David :Bienvenu]

If message quarantining is turned off (not the default), pop3 incoming move mail filters get the message size wrong by two bytes too many in the resulting msg hdr. This is relatively harmless, but obviously should be fixed. I suspect this is a flush issue.

Comment 1

[David :Bienvenu]

Attachment: proposed fix

I'll try to see if I can come up with a unit test for this.

Comment 2

[David :Bienvenu]

Attachment: fix with unit test

This makes sure we flush full messages, and extends the pop3FilterMove test to test that the message is right. In debug builds, we assert, w/o the core change, and I believe in release mode it'll fail as well.

Comment 3

[David :Bienvenu]

fix checked in - http://hg.mozilla.org/comm-central/rev/986abadfbeb7

Comment 4

[David :Bienvenu]

Attachment: fix msg download limiting case

We have the exact same issue if message download limit is set. So I'm just always going to flush. Extended unit test to test for this as well.

Comment 5

[David :Bienvenu]

follow-on fix landed on trunk - http://hg.mozilla.org/comm-central/rev/9843a6596561

Comment 6

[David :Bienvenu]

and backed out and relanded - http://hg.mozilla.org/comm-central/rev/cb2b8fd3f517

Comment 7

[Mark Banner (:standard8)]

Checked into branches:

http://hg.mozilla.org/releases/comm-aurora/rev/9306cdde5483
http://hg.mozilla.org/releases/comm-beta/rev/9bdfa24dedd9