Closed
Bug 715947
Opened 12 years ago
Closed 12 years ago
add telemetry for number of setTimeouts during an nsITimer run
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla12
People
(Reporter: froydnj, Assigned: froydnj)
References
Details
Attachments
(1 file, 1 obsolete file)
1.74 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
Splitting this off from bug 715380. Also, I'm not entirely sure what the desired effect is here. For something like: setTimeout(...) // assume each one is long enough to overlap subsequent ones setTimeout(...) setTimeout(...) setTimeout(...) What information do you want collected from that? The number of pending timeouts when we schedule a new one?
Comment 1•12 years ago
|
||
I know very little of this, so bz or khuey will have to help clarify. For every nsITimer execution that contains setTimeout handlers, we should record the number of those into a histogram.
If I understand the code correctly, nsGlobalWindow::RunTimeout is called once per XPCOM timeout firing. It may dispatch multiple nsTimeouts (though it's called with a single nsTimeout. The loops in that function will be of interest to you.
Assignee | ||
Comment 3•12 years ago
|
||
OK, so that wasn't so hard. Do note that this patch uses Telemetry::AutoCounter from bug 716657; I'll make sure they go in in the proper order.
Attachment #587332 -
Flags: review?(bzbarsky)
Comment 4•12 years ago
|
||
Comment on attachment 587332 [details] [diff] [review] patch for timers fired per nsITimer r=me
Attachment #587332 -
Flags: review?(bzbarsky) → review+
Comment 5•12 years ago
|
||
Comment on attachment 587332 [details] [diff] [review] patch for timers fired per nsITimer Should prefix this histogram as DOM_
Assignee | ||
Comment 6•12 years ago
|
||
Adding DOM_ prefix per Taras's suggestion. Carrying over r+.
Attachment #587332 -
Attachment is obsolete: true
Attachment #588083 -
Flags: review+
Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
Comment 8•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d41fbe450000
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•