71632 - OS/2 - convert wdgtos2.dll into a XPCOM module

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[achimha]

I started work on widget/src/os2 to convert it into a real XPCOM module like
the Xlib version. I think I got it almost right but not fully. I need some
help I guess. It builds fine but when starting Mozilla, I get
nsNativeComponentLoader: GetFactory(WDGTOS2) Load FAILED with error:
Range error
The classes it exports can be found in components.reg (searched for
contract ids) so that seems to have worked fine.

Comment 1

[achimha]

Attachment: the easy part, mark as a component

Comment 2

[achimha]

Attachment: whee - the diff is larger than the file...

Comment 3

[achimha]

Yay, I got it working! I had to remove the old style registration in the
bootstrap code for the widget library on OS/2. Isn't it strange that we include
code in /mozilla/webshell/test/viewer in the retail build? I would have never
found this without LXR...
I'll attach a new diff for the widget/src/os2 code and for the bootstrap
code. Makefile.in patch is still valid.
CC'ing blizzard and pavlov cause they helped with bug 68343 which was the
same thing for gfx_os2.

Comment 4

[achimha]

Attachment: new diff with missing components added and nsTimer contract id corrected

Comment 5

[achimha]

Attachment: handle OS/2 like Unix for widget library - we're a full blown XPCOM component now!

Comment 6

[Mike Kaply [:mkaply]]

I'm seeing two problems with this.

1. Sidebar doesn't come up at first.

2. Windows are positioned with titlebar off the screen.

Are you seeing this Achim?

Comment 7

[achimha]

Mike, I'm not seeing any of your problems. Technically, the only thing this
change could affect is instantiating some contained classes. This would be
visible in the debug build console log (I first had incorrect timer contract
ID because timer was the only thing that was instantiated using its contract
ID but I saw the error on the console).

Did you delete dist/bin/wdgtos2.dll and components.reg?

Comment 8

[achimha]

Attachment: modelled contract ids after gtk cause this looks better than xlib code

Comment 9

[Stuart Parmenter]

r=pavlov

Comment 10

[Mike Kaply [:mkaply]]

Fix checked in

Comment 11

[achimha]

done