Open
Bug 716418
Opened 12 years ago
Updated 2 years ago
Meaningless boolean flag parameters to methods on nsISelectionController
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
NEW
People
(Reporter: neil, Unassigned)
Details
Attachments
(1 file)
50.67 KB,
patch
|
Details | Diff | Splinter Review |
nsISelectionController has the following scrolling and movement methods: CharacterMove ScrollCharacter CompleteMove CompleteScroll PageMove ScrollPage LineMove ScrollLine WordMove IntraLineMove The scrolling methods currently take a boolean parameter which indicates the direction of the scroll. The movement methods currently take two boolean parameters, one which indicates the direction of the movement and the other indicates whether to extend or collapse the selection.
Reporter | ||
Comment 1•12 years ago
|
||
I replaced those methods with three: Scroll, Collapse and Extend, which accept one of 12 motion codes. There is also part of an idea to make Ctrl+Left/Right scroll to the beginning/end of the line, but the code has been disabled. It does compile, at least. I don't know whether my substitutions are correct, or whether it passes any tests.
Updated•6 years ago
|
Product: Core → Core Graveyard
Assignee | ||
Updated•6 years ago
|
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
Updated•2 years ago
|
Severity: minor → S4
You need to log in
before you can comment on or make changes to this bug.
Description
•