Closed
Bug 716677
Opened 12 years ago
Closed 12 years ago
test_bug296375.xul makes incorrect assumptions about the event ordering
Categories
(Core :: DOM: Events, defect)
Tracking
()
RESOLVED
FIXED
mozilla12
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
804 bytes,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
This test implicitly assumes that events added in order will be fired in order. We should just call finish when we know that we're done.
Assignee | ||
Comment 1•12 years ago
|
||
Comment 2•12 years ago
|
||
Comment on attachment 587138 [details] [diff] [review] Patch (v1) Does addLoadEvent not guarantee the right order? That would be bug in mochitest. addEventListener does guarantee the order. Is mochitest not using that? But anyway, looks ok.
Attachment #587138 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 3•12 years ago
|
||
No, mochitest rolls its own implementation, IIRC.
Assignee | ||
Comment 4•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/2b4c5610aa69
Target Milestone: --- → mozilla12
Assignee | ||
Comment 5•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2b4c5610aa69
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•