716863 - blogspot.com pages are not properly framed after page is scrolled

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Carla Nadastean]

Attachment: screenshot

Build: 12.0a1 (2012-01-09) Device: HTC Desire Z (Android 2.3)

Steps to reproduce:
1. Go to http://android-developers.blogspot.com/2011/07/debugging-android-jni-with-checkjni.html
2. Try to scroll from the bottom of the page.

Expected Result:
Page content is scrolled successfully.

Actual Result:
Page content is scrolled but the page is no longer properly framed. (screenshot attached)

Comment 1

[Carla Nadastean]

Reproducible also on Aurora:
11.0a2 (2012-01-09) HTC Desire Z (Android 2.3)

Comment 2

[Kartikaya Gupta (email:[e-mail])]

I looked at this a bit, and it seems to be happening because the subdocument scrolling code in browser.js takes over partway through the pan, so we get a little bit of panning (possibly into overscroll) in PZC, and then the iframe pans the rest of the touch movement. When the touch move stops, we don't bounce back because we're still sending the movement to the subdocument scroller.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Attachment: (1/2) Bounce back if overscrolled after flinging subdocument

It only gets into this state if you touch down on a subdocument and pan/fling before the Gesture:ShowPress/Panning:Override event round-trip has time to complete.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Attachment: (2/2) Abort subdocument fling runnable when the subdoc stops scrolling

This is just so that the bounce-back happens faster if you happen to fling a subdoc very aggressively when you're already near the edge of the subdoc. Without this it could take a few seconds for the bounce-back to happen because it has to wait for the fling runnable to exhaust itself even though it's not visibly moving anything.

Comment 7

[Chris Lord [:cwiiis]]

Comment on attachment 590225 [details] [diff] [review]
(1/2) Bounce back if overscrolled after flinging subdocument

Review of attachment 590225 [details] [diff] [review]:
-----------------------------------------------------------------

Looks alright to me.

Comment 8

[Chris Lord [:cwiiis]]

Comment on attachment 590227 [details] [diff] [review]
(2/2) Abort subdocument fling runnable when the subdoc stops scrolling

Review of attachment 590227 [details] [diff] [review]:
-----------------------------------------------------------------

Also looks good.

Comment 9

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e5f5c1c96f4e
https://hg.mozilla.org/integration/mozilla-inbound/rev/e862a60fdb13

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e5f5c1c96f4e
https://hg.mozilla.org/mozilla-central/rev/e862a60fdb13

Comment 11

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 590225 [details] [diff] [review]
(1/2) Bounce back if overscrolled after flinging subdocument

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: It's possible to get stuck in overscroll after panning an iframe
Testing completed (on m-c, etc.): On m-c
Risk to taking this patch (and alternatives if risky): Potentially regression in fling behaviour

Comment 12

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 590227 [details] [diff] [review]
(2/2) Abort subdocument fling runnable when the subdoc stops scrolling

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: If you fling a subdocument really hard and it hits the end and stops scrolling, the overall page may still remain in overscroll for a few more seconds rather than bouncing back immediately
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): potentially regressions in subdocument scrolling.

Comment 13

[Martijn Wargers (dead)]

Verified fixed in current Native trunk build on the LG Optimus Black, Android 2.2.2.

Comment 14

[Alex Keybl [:akeybl]]

Comment on attachment 590225 [details] [diff] [review]
(1/2) Bounce back if overscrolled after flinging subdocument

[Triage Comment]
Mobile only - approved for Aurora.

Comment 15

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b32116534dc2

Comment 16

[Matt Brubeck (:mbrubeck)]

(and the other patch landed on Aurora at the same time)
https://hg.mozilla.org/releases/mozilla-aurora/rev/bd5c7b73ce79