Closed
Bug 717166
Opened 13 years ago
Closed 11 years ago
'this' inside Hotkey.onPress is [object Sandbox]
Categories
(Add-on SDK Graveyard :: General, defect, P3)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dietrich, Assigned: jsantell)
References
Details
Attachments
(1 file)
it should be the Hotkey object.
Was it ever the Hotkey object? Did this change with 1.4?
Priority: -- → P3
|
||
Updated•11 years ago
|
Blocks: sdk/hotkeys
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → jsantell
|
|
Assignee | |
Comment 2•11 years ago
|
||
`this` is not [Sandbox] at this point, but it was undefined; should be the hotkey instance itself, I think.
Attachment #800121 -
Flags: review?(zer0)
|
||
Updated•11 years ago
|
Attachment #800121 -
Flags: review?(zer0) → review+
|
||
Comment 3•11 years ago
|
||
Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/f698ea91f47f4fc12d4d1559b089bfa5da3ba052 Bug 717166 Change context of hotkey onPress to the hotkey instance itself https://github.com/mozilla/addon-sdk/commit/bdc2ffcef77578494dfc0ff42aa3a51c018852e0 Merge pull request #1233 from jsantell/717166-change-hotkey-onpress-context fix Bug 717166 Change context of hotkey onPress to the hotkey instance itself, r=@ZER0
|
|
||
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•