Closed Bug 717243 Opened 12 years ago Closed 12 years ago

Intermittent TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/geolocation/test_clearWatch_invalid.html | finished in a non-clean fashion (in /tests/dom/tests/mochitest/geolocation/test_clearWatch.html)

Categories

(Core :: DOM: Geolocation, defect)

Product:
Core
Component:
DOM: Geolocation
Version:
12 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla12

People

(Reporter: emorley, Assigned: jdm)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Handle multiple geolocation callbacks that can occur before a clearWatch call.
1.60 KB, patch
dougt
: review+
Details | Diff | Splinter Review 
Rev3 Fedora 12 mozilla-inbound debug test mochitests-3/5
On https://hg.mozilla.org/integration/mozilla-inbound/rev/d2ff5d57658d

7648 INFO TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/geolocation/test_clearWatch_invalid.html | finished in a non-clean fashion (in /tests/dom/tests/mochitest/geolocation/test_clearWatch.html)

https://tbpl.mozilla.org/php/getParsedLog.php?id=8480176&tree=Mozilla-Inbound

Caught by bug 668728.
I landed some debugging code to help me figure out what's going on here:

https://hg.mozilla.org/integration/mozilla-inbound/rev/3cdbbe54fab9
^ that one being with-debugging.
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1326829352.1326830416.15618.gz
OS X 10.5 comm-central-trunk debug test mochitests-3/5 on 2012/01/17 11:42:32
{
4450 INFO TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/geolocation/test_clearWatch_invalid.html | finished in a non-clean fashion (in /tests/dom/tests/mochitest/geolocation/test_clearWatch.html)
}
OS: Linux → All
Hardware: x86 → All
The problem here is that we're receiving two updates right after each other for some reason.
We only want a single callback to be performing the checks and finishing the test, but it's conceivable that we could get multiple ones before clearWatch is called.
Attachment #591004 - Flags: review?(doug.turner)
Assignee: nobody → josh
Attachment #591004 - Flags: review?(doug.turner) → review+
https://hg.mozilla.org/mozilla-central/rev/badb5fd30031
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
Whiteboard: [orange]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: