Closed Bug 717278 Opened 12 years ago Closed 12 years ago

Vector should have const and non-const begin()

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Version:
Other Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla12

People

(Reporter: jorendorff, Assigned: jorendorff)

Details

Attachments

(1 file)

v1
3.24 KB, patch
luke
: review+
Details | Diff | Splinter Review 
Vector has both const and non-const end() methods but only a const begin() method, and it returns a pointer-to-non-const T, which seems wrong to me.
Indeed, Vector used to have this right; it looks like it regressed in http://hg.mozilla.org/mozilla-central/rev/b60ac564e39d#l1.253.
Attached patch v1 — — Splinter Review 
Assignee: general → jorendorff

        Attachment #587745 -
        Flags: review?(luke)

    
  

        Attachment #587745 -
        Flags: review?(luke) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/11ba93db719a
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: