Closed
Bug 717370
Opened 13 years ago
Closed 12 years ago
Cleanup range-using and nearby code in editor
Categories
(Core :: DOM: Editor, defect)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla12
People
(Reporter: Ms2ger, Assigned: Ms2ger)
Details
Attachments
(1 file)
|
13.32 KB,
patch
|
smaug
:
review+
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
Looking at the patches for bug 682611, I noticed at least three helper functions to create a range and set its start and end points, and one function that did it inline. I'd say we can provide that in one place. Smaug, could you review the changes in nsRange.{h,cpp}? Also, various ugly and slow stuff I noticed.
Attachment #587791 -
Flags: review?(bugs)
|
Assignee | |
Updated•13 years ago
|
Attachment #587791 -
Flags: review?(ehsan)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 587791 [details] [diff] [review] Patch v1 Review of attachment 587791 [details] [diff] [review]: ----------------------------------------------------------------- r=me on the editor parts.
Attachment #587791 -
Flags: review?(ehsan) → review+
|
||
Updated•13 years ago
|
Attachment #587791 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Comment 2•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/fb524533a477
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in
before you can comment on or make changes to this bug.
Description
•