717562 - Search service should use async XHR instead of DOMParser::parseFromStream

Status: RESOLVED WORKSFORME

(Firefox :: Search, defect, P5)

Description

[Henri Sivonen (:hsivonen)]

nsIDOMParser::parseFromStream needs to go away in order to unblock an XML code path rewrite and in any case chrome code shouldn't be doing synchronous IO on the main thread. Please migrate toolkit/components/search/nsSearchService.js to use asynchronous XHR instead of nsIDOMParser.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

The search service currently depends on sync IO to fulfill API promises. Bug 699856 (or its followup bugs) is going to try to address that. If you need to unblock bug 717561 before that lands, we can consider moving to Sync XHR, I guess, but I'd like to avoid that.

Comment 2

[Henri Sivonen (:hsivonen)]

Sync XHR is worse than nsIDOMParser::parseFromStream. It doesn't make sense to move to sync XHR even as an intermediate step. Let's make this one wait for bug 699856 then.

Comment 3

[David Teller [:Yoric] - still alive but not very active]

I actually had a prototype of the search service using XHR in some parts. Once bug 699856 + followups have landed, I will get to work on this.

Comment 4

[David Teller [:Yoric] - still alive but not very active]

I actually had a prototype of the search service using XHR in some parts. Once bug 699856 + followups have landed, I will get to work on generalizing this.

Comment 5

[David Teller [:Yoric] - still alive but not very active]

No time to work on this.

Comment 6

[Thomas Wisniewski]

I don't mind helping with this, if it's worth converting parseFromStream over to a sync XHR. Or is it possible to make these parts async while we're at it? From what I gather it doesn't look like it...

Comment 7

[David Teller [:Yoric] - still alive but not very active]

Well, as per comment 2, sync XHR is not a good idea. So if you want to make it async, that would be nicer.

Comment 8

[Mark Banner (:standard8)]

I can't see any use of this in search in latest mozilla-central