Closed Bug 717613 Opened 12 years ago Closed 12 years ago

Make sure the primary selection is not updated too often in the Source Editor

Categories

(DevTools :: General, defect, P3)

All
Linux
defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 13

People

(Reporter: msucan, Assigned: msucan)

References

Details

(Whiteboard: [sourceeditor][orion][fixed-in-fx-team])

Attachments

(1 file, 2 obsolete files)

Since bug 695035 landed we update the X11 primary selection when needed. We should limit the number of updates to only one after 250-500 ms of user inactivity. This would avoid potential lockups while working with really big files (and big selections).
Assignee: nobody → mihai.sucan
Attached patch proposed patch (obsolete) — Splinter Review
Proposed patch. Please let me know if this approach is fine with you. Thanks!
Attachment #592249 - Flags: review?(rcampbell)
Status: NEW → ASSIGNED
Depends on: 712982
Comment on attachment 592249 [details] [diff] [review]
proposed patch

yeah, this looks ok to me. Why 250ms though. Why not 25ms? or 100?
(In reply to Rob Campbell [:rc] (robcee) from comment #2)
> Comment on attachment 592249 [details] [diff] [review]
> proposed patch
> 
> yeah, this looks ok to me. Why 250ms though. Why not 25ms? or 100?

I picked it arbitrarily, I was also unsure how short the delay should be. Do you want me to put a different value?
yeah, I think 50ms or 100ms is probably sufficient. I feel like at 250ms, some fast users could switch windows and not have their clipboard populated.
Attached patch updated patch (obsolete) — Splinter Review
Changed the timeout from 250ms to 100ms. Please let me know if further changes are needed.

Thank you!
Attachment #592249 - Attachment is obsolete: true
Attachment #592249 - Flags: review?(rcampbell)
Attachment #593582 - Flags: review?(rcampbell)
Blocks: 700893
Attachment #593582 - Flags: review?(rcampbell) → review+
Attachment #593582 - Attachment is obsolete: true
Comment on attachment 595788 [details] [diff] [review]
[in-fx-team] rebased patch

Landed:
https://hg.mozilla.org/integration/fx-team/rev/00bce5149395
Attachment #595788 - Attachment description: rebased patch → [in-fx-team] rebased patch
Whiteboard: [sourceeditor][orion] → [sourceeditor][orion][fixed-in-fx-team]
Comment on attachment 595788 [details] [diff] [review]
[in-fx-team] rebased patch

backed out due to test failure:
https://hg.mozilla.org/integration/fx-team/rev/e732067ca81e
Attachment #595788 - Attachment description: [in-fx-team] rebased patch → rebased patch
Whiteboard: [sourceeditor][orion][fixed-in-fx-team] → [sourceeditor][orion][backedout]
Comment on attachment 595788 [details] [diff] [review]
[in-fx-team] rebased patch

Landed:
https://hg.mozilla.org/integration/fx-team/rev/ac5158b80fdf
Attachment #595788 - Attachment description: rebased patch → [in-fx-team] rebased patch
Whiteboard: [sourceeditor][orion][backedout] → [sourceeditor][orion][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/ac5158b80fdf
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 13
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: