Closed
Bug 717616
Opened 12 years ago
Closed 12 years ago
Empty jsloader and jsloader\resource directories added to the Firefox 10.0b4 installer and thereby to the installation which do not get removed on uninstall
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla15
People
(Reporter: pauly, Assigned: gaston)
Details
Attachments
(1 file)
1.29 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
Steps to reproduce: 1. Install Firefox 10b4 2. Uninstall Actual results: Empty folder left: "c:\Program Files (x86)\Mozilla Firefox\jsloader\resource" Expected results: All data removed
Updated•12 years ago
|
Component: General → NSIS Installer
Product: Firefox → Toolkit
QA Contact: general → nsis.installer
Comment 1•12 years ago
|
||
Looks like there are empty directories being added in the beta build. http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/10.0b4-candidates/build1/win32/en-US/Firefox%20Setup%2010.0b4.exe We could teach the installer to clean these sort of things up but it would be better to just not add empty / unused directories as we have always done.
Component: NSIS Installer → Installer
Product: Toolkit → Firefox
QA Contact: nsis.installer → installer
Updated•12 years ago
|
Summary: Uninstalling Firefox doesn't clear data from Program Files → Empty jsloader and jsloader\resource directories added to the installer and thereby to the installation which do not get removed on uninstall
Updated•12 years ago
|
Summary: Empty jsloader and jsloader\resource directories added to the installer and thereby to the installation which do not get removed on uninstall → Empty jsloader and jsloader\resource directories added to the Firefox 10.0b4 installer and thereby to the installation which do not get removed on uninstall
Comment 2•12 years ago
|
||
They're also present in installers going all the way back to 8.0b1, so this would probably changed in the 6 weeks Fx8 was development on mozilla-central.
Comment 3•12 years ago
|
||
I think this was caused by bug 655678. I suspect that all that is needed is the removal of the jsloader dir along with its contents as the last action in http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/installer/packager.mk#460
Comment 4•12 years ago
|
||
I wanted to mention previously that I seen this too but forgot.
Paul, can you confirm that this only happens on Windows 7 (as per the Platform field in this bug)?
Reporter | ||
Comment 6•12 years ago
|
||
Same behavior on Win XP and Vista. But I would say this is reproducible on all Windows.
(In reply to Paul Silaghi [QA] from comment #6) > Same behavior on Win XP and Vista. But I would say this is reproducible on > all Windows. ...and what about Linux and Mac?
Reporter | ||
Comment 8•12 years ago
|
||
There is no installer on Mac and Linux
Comment 9•12 years ago
|
||
The jsloader dirs are actually present in the linux tarballs (32 and 64bit builds), but not included in the mac dmg.
Assignee | ||
Comment 10•12 years ago
|
||
Starting with firefox 13.0beta i'm also seeing an empty jssubloader/185/resource/ dir, along jsloader/resource/. This is after 'make install' when building from a source tarball on OpenBSD (so, a unix platform). jsloader/resource appeared between 7.0.1 and 8.0.1 and is present in releases too, not only betas.
Assignee | ||
Comment 11•12 years ago
|
||
This patch seems to fix the issue for me, i've generated a package through make package which didnt contain jsloader nor jssubloader dirs. Only tested on OpenBSD, so maybe worth a try run ?
Attachment #622672 -
Flags: review?(mh+mozilla)
Updated•12 years ago
|
Attachment #622672 -
Flags: review?(mh+mozilla) → review+
Comment 12•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/a0a502079098
Target Milestone: --- → Firefox 15
Updated•12 years ago
|
Assignee: nobody → landry
Updated•12 years ago
|
Component: Installer → Build Config
Product: Firefox → Core
QA Contact: installer → build-config
Target Milestone: Firefox 15 → mozilla15
Comment 13•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a0a502079098
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 14•12 years ago
|
||
Verified fixed on FF 15.0a1 (2012-05-15) on Win 7, Ubuntu 12.04 and Mac OS 10.6. No more jsloader dirs on FF packages.
Status: RESOLVED → VERIFIED
Assignee | ||
Comment 15•12 years ago
|
||
Is it worth backporting to aurora/beta ?
Comment 16•12 years ago
|
||
A webapprt directory is now left in the installation folder when uninstalling Firefox 15.0a2. What could cause this?
Comment 17•12 years ago
|
||
> A webapprt directory is now left in the installation folder when > uninstalling Firefox 15.0a2. What could cause this? The web app work introduced that regression. Details can be found here: Bug 757978
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•