Closed Bug 717870 Opened 13 years ago Closed 12 years ago

Space is incorrectly ignored when adding text to <svg:text>

Categories

(Core :: SVG, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla12

People

(Reporter: jruderman, Assigned: longsonr)

References

Details

Attachments

(2 files)

      No description provided.
Confirmed. Same behavior at least as far back as Firefox 3.5.16, so not a regression, at least not a recent one.
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.16) Gecko/20101130 Firefox/3.5.16
OS: Mac OS X → All
Hardware: x86_64 → All
Assignee: nobody → longsonr
Attached patch patchSplinter Review
Attachment #588486 - Flags: review?(dholbert)
Comment on attachment 588486 [details] [diff] [review]
patch

Looks great!

One suggestion -- a brief comment would be helpful above or inside SetWhitespaceHandling(), just to be clear up-front what it's trying to do.

Something like
> // Trim whitespace up to the first non-whitespace frame
> // and after the last non-whitespace frame.

r=me with that
Attachment #588486 - Flags: review?(dholbert) → review+
pushed https://hg.mozilla.org/integration/mozilla-inbound/rev/256c57537507
Flags: in-testsuite+
Target Milestone: --- → mozilla12
https://hg.mozilla.org/mozilla-central/rev/256c57537507
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Blocks: refdyn
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: