717958 - OMTC: Access to OGL FPS counter preference should only happen on the main thread

Status: RESOLVED FIXED

(Core :: Graphics, defect, P2)

Description

[Ali Juma [:ajuma]]

Bug 683745 made the OGL FPS counter pref 'live', so that changes take effect without a restart. However, with OMTC, this means that we are accessing preferences off the main thread (but we shouldn't be -- see bug 619487). We should either make this pref non-live again, or watch for changes to the pref on the main thread and then send a message to the compositor thread whenever there's a change.

Comment 1

[Joe Drew (not getting mail)]

Does this need to block bug 725095?

Comment 2

[Ali Juma [:ajuma]]

The correct functioning of the FPS counter itself isn't critical for bug 725095, but if accessing the pref off the main thread can cause other problems, then we need to fix this. Let's be cautious and make this block.

Comment 3

[Benoit Girard (:BenWa)]

Attachment: Dispatch a readpref event to main thread

Comment 4

[Ali Juma [:ajuma]]

Comment on attachment 600552 [details] [diff] [review]
Dispatch a readpref event to main thread

Review of attachment 600552 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/opengl/LayerManagerOGL.cpp
@@ +364,5 @@
>        msg += NS_LITERAL_STRING("TEXTURE_RECTANGLE");
>      console->LogStringMessage(msg.get());
>    }
>  
> +  if (!NS_IsMainThread()) {

Remove the negation here.

Comment 5

[Mozilla RelEng Bot]

Autoland Patchset:
	Patches: 600552
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/pushloghtml?changeset=93d013a929a1
Try run started, revision 93d013a929a1. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=93d013a929a1

Comment 6

[Mozilla RelEng Bot]

Try run for 93d013a929a1 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=93d013a929a1
Results (out of 215 total builds):
    success: 177
    warnings: 24
    failure: 14
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-93d013a929a1

Comment 7

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/projects/maple/rev/f99d62aca00a
https://hg.mozilla.org/integration/mozilla-inbound/rev/32fcf3259a47

Comment 8

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/32fcf3259a47