718161 - Dehydra fails to build against the javascript engine in FF10esr

Status: RESOLVED WONTFIX

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Mike Hommey [:glandium]]

dehydra_ast.c: In function 'dehydra_makeVar':
dehydra_ast.c:51:21: error: invalid operands to binary == (have 'jsval' and 'jsval')
dehydra_ast.c: In function 'dehydra_initVar':
dehydra_ast.c:127:11: error: invalid operands to binary == (have 'jsval' and 'jsval')

Comment 1

[Joshua Cranmer [:jcranmer]]

This is just the tip of the iceberg; there's several more in several files. Basically, we need to

s/\([a-z_]*\) == JSVAL_VOID/JSVAL_IS_VOID(\1)/g
s/\([a-z_]*\) != JSVAL_VOID/!JSVAL_IS_VOID(\1)/g
s/\([a-z_]*\) == JSVAL_TRUE/JSVAL_TO_BOOLEAN(\1) == JS_TRUE/g

[and maybe a few others; I'm using trunk spidermonkey right now which... has even more failures]

Comment 2

[Mike Hommey [:glandium]]

Considering bug 735599, 10esr should be a baseline we need to keep building against.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Patch v1

With the patch I get the following:

python unit_test_harness.py dehydra "/usr/bin/g++-4.6"
..................xx...................................................
Test Failure: 
    Test command: /usr/bin/gcc-4.6 -c -fplugin=../gcc_dehydra.so -o /dev/null -fplugin-arg-gcc_dehydra-script=test_strict.js onefunc.cc
    Failure msg: Expected 'OK' output; Errors:
 ../libs/xhydra.js:52: JS STRICTJS Exception: ReferenceError: reference to undefined property this._loc
../libs/xhydra.js:52:	#0: print("OK")
./test_strict.js:12:	#1: process_function([object DehydraDecl],[object Array])

Test Failure: 
    Test command: /usr/bin/g++-4.6 -c -fplugin=../gcc_dehydra.so -o /dev/null -fplugin-arg-gcc_dehydra-script=test_strict.js onefunc.cc
    Failure msg: Expected 'OK' output; Errors:
 ../libs/xhydra.js:52: JS STRICTJS Exception: ReferenceError: reference to undefined property this._loc
../libs/xhydra.js:52:	#0: print("OK")
./test_strict.js:12:	#1: process_function([object DehydraDecl],[object Array])


Unit Test Suite Summary:
     69 passed
      2 failed
      0 error(s)

Not sure how to debug this.

Comment 4

[Joshua Cranmer [:jcranmer]]

Dehydra and treehydra are no longer maintained by Mozilla.