718173 - Move the #toolbar-buttons to the right of the #tabbar-toolbar

Status: RESOLVED WONTFIX

(Thunderbird :: Toolbars and Tabs, defect)

Description

[Richard Marti (:Paenglab)]

With Lightning or an other Add-on installed with buttons in #toolbar-buttons could make the behavior of customization a bit strange.

When customizing you can put the item on the right of the tabs (here specially between tabs and Lightning buttons). But then the items jumps on the right of the Lightning buttons.

It is also possible to let fall the items directly over the other buttons of the #tabbar-toolbar. Then the items stay where they are put.

With Bug 717264 it could be no item is in this toolbar initially then it isn't possible to put the items directly in this toolbar and the behavior is more obvious.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: Patch

This patch moves the #toolbar-buttons to the right of the #tabbar-toolbar.

This makes now the QFB button isn't directly beside the alltabs-button with a Add-on installed on the default configuration.

Blake, what do you mean is this okay or would you leave the toolbars as they are?

Comment 2

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 588618 [details] [diff] [review]
Patch

So, as I understand it, Lightning is going to switch back to toolbar buttons, so shouldn't have this issue anymore.  (Cc-ing Fallen for confirmation.)

I think what I'ld really like to see is for us just to remove tabmail-buttons, since anything that went there can now go in tabbar-toolbar instead, and be more customizable, too!  Given that, I think I'm going to ui-r- this patch, and clear the review request.  (Cc-ing Sancus to see how many extensions currently use the "tabmail-buttons" element, and how easy it would be to add this to the compatibility bump check.)

Thanks,
Blake.

Comment 3

[Jim Porter (:squib)]

(In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #2)
> I think what I'ld really like to see is for us just to remove
> tabmail-buttons, since anything that went there can now go in tabbar-toolbar
> instead, and be more customizable, too!

I'd recommend keeping tabmail-buttons around for a little while for backwards compatibility (or checking to make sure no popular add-ons are using it).

Comment 4

[Blake Winton (:bwinton) (:☕️)]

I'm hoping Sancus could run that check for us.  If not, then I agree we probably want to keep it around, and then putting it to the right seems reasonable.

Comment 5

[Richard Marti (:Paenglab)]

With Bug 719006 the Lightning buttons are now in the tabbar-toolbar.