718252 - Implement inline editing for renaming attachments when composing

Status: NEW

(Thunderbird :: Message Compose Window, enhancement)

Description

[Jim Porter (:squib)]

+++ This bug was initially created as a clone of Bug #526998 +++

We should allow inline editing of attachment names in the compose window instead of opening a dialog box. I have a WIP patch for this, which I'll clean up and post sometime soon (hopefully).

Comment 1

[Jim Porter (:squib)]

Attachment: WIP patch

How about this? It probably doesn't work quite right on anything but Linux, since I haven't given other themes the proper CSS, but that should be easy.

Comment 2

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 648973 [details] [diff] [review]
WIP patch

Only tested on Linux, but I'm loving it!  ui-r=me!

Thanks,
Blake.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 648973 [details] [diff] [review]
WIP patch

Review of attachment 648973 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me.

What happens to Filelinks? I guess we can't really support renaming them once they're already uploaded? That'd mean a deletion and a re-upload if the storage API doesn't support renaming. :/

::: mail/base/content/mailWidgets.xml
@@ +484,5 @@
>        ]]></handler>
>      </handlers>
>    </binding>
>  
> +  <binding id="attachmentitemediting" extends="chrome://messenger/content/mailWidgets.xml#attachmentitem">

attachmentitemediting is pretty hard to read. Can we use attachmentitem-editing instead?

Comment 4

[:aceman]

Squib, can you finish this up?

Comment 5

[Jim Porter (:squib)]

Shouldn't be too hard to finish up. I'll try to get to it before, say... December? Things have been getting ever-so-slightly less busy for me, so I'm hoping I can get some more of my WIP TB patches landed.

Comment 6

[Jim Porter (:squib)]

Unassigning myself to let other folks work on this if they want.

Comment 7

[Thomas D. (:thomas8)]

Bug 1319052 has recently done something similar for inline renaming of address book items in the tree.