Closed Bug 718324 Opened 12 years ago Closed 12 years ago

[Linux, QT] "Warning: package error or possible missing or unnecessary file: bin/chrome/icons/default/default16.png (package-manifest, 315)." (+ 2 more)

Categories

(Firefox Build System :: General, defect, P1)

Product:
Firefox Build System
Component:
General
Platform:
x86
Linux
Type:
defect

Tracking

(firefox9 wontfix, firefox10 wontfix, firefox11 wontfix, firefox12 verified, firefox-esr10 wontfix)

Status:
VERIFIED FIXED
Milestone:
mozilla13
Tracking Flags:
Tracking Status
firefox9 --- wontfix
firefox10 --- wontfix
firefox11 --- wontfix
firefox12 --- verified
firefox-esr10 --- wontfix

People

(Reporter: sgautherie, Assigned: sgautherie)

References

Details

Attachments

(1 file)

(Av1) Fix condition for packaging 'default*.png' [Checked in: Comments 3 and 6]
1014 bytes, patch
ted
: review+
akeybl
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
https://tbpl.mozilla.org/php/getParsedLog.php?id=8566753&tree=Try&full=1
Linux QT try build on 2012-01-15 09:28:37 PST for push 0f7ff1139bde
[
Error: package error or possible missing or unnecessary file: bin/chrome/icons/default/default16.png (package-manifest, 315).
Error: package error or possible missing or unnecessary file: bin/chrome/icons/default/default32.png (package-manifest, 316).
Error: package error or possible missing or unnecessary file: bin/chrome/icons/default/default48.png (package-manifest, 317).
}

NB: It's an error in this log, because I was checking bug 713132.
Flags: in-testsuite-
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED

        Attachment #592502 -
        Flags: review?(ted.mielczarek)

    
  
Blocks: 511642

          status-firefox10:
          --- → wontfix

          status-firefox11:
          --- → wontfix

          status-firefox9:
          --- → wontfix
Target Milestone: --- → Firefox 12

    
    

    
  
Ping for review.

        Attachment #592502 -
        Flags: review?(ted.mielczarek) → review+

    
    

    
  
Comment on attachment 592502 [details] [diff] [review]
(Av1) Fix condition for packaging 'default*.png'
[Checked in: Comments 3 and 6]

https://hg.mozilla.org/mozilla-central/rev/882cb76f5b34


[Approval Request Comment]
Regression caused by (bug #): (old)
User impact if declined: None, but ("last" to) blocks bug 713132.
Testing completed (on m-c, etc.): this comment.
Risk to taking this patch (and alternatives if risky): None.
String changes made by this patch: None.

        Attachment #592502 -
        Attachment description: (Av1) Fix condition for packaging 'default*.png' → (Av1) Fix condition for packaging 'default*.png'
[Checked in: Comment 3]

        Attachment #592502 -
        Flags: approval-mozilla-aurora?

    
  
Status: ASSIGNED → RESOLVED
Closed: 12 years ago

          status-firefox12:
          --- → affected
Resolution: --- → FIXED
Target Milestone: Firefox 12 → Firefox 13

    
    

    
  
https://tbpl.mozilla.org/php/getParsedLog.php?id=9304724&tree=Firefox&full=1
Linux QT mozilla-central build on 2012-02-13 14:07:54 PST for push 882cb76f5b34

V.Fixed
Status: RESOLVED → VERIFIED

    
    

    
  
Comment on attachment 592502 [details] [diff] [review]
(Av1) Fix condition for packaging 'default*.png'
[Checked in: Comments 3 and 6]

[Triage Comment]
Simple, low-risk change early in Aurora 12. Approved.

        Attachment #592502 -
        Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

    
  
Keywords: checkin-needed
Whiteboard: [c-n: to m-a]

    
    

    
  
Comment on attachment 592502 [details] [diff] [review]
(Av1) Fix condition for packaging 'default*.png'
[Checked in: Comments 3 and 6]

http://hg.mozilla.org/releases/mozilla-aurora/rev/1feee394bb27

        Attachment #592502 -
        Attachment description: (Av1) Fix condition for packaging 'default*.png'
[Checked in: Comment 3] → (Av1) Fix condition for packaging 'default*.png'
[Checked in: Comments 3 and 6]

          status-firefox12:
          affected → fixed
Keywords: checkin-needed
Whiteboard: [c-n: to m-a]

    
    

    
  
https://tbpl.mozilla.org/php/getParsedLog.php?id=9531687&tree=Mozilla-Aurora&full=1
Linux QT mozilla-aurora build on 2012-02-22 09:07:18 PST for push 1feee394bb27

firefox12: verified.

          status-firefox12:
          fixed → verified
Component: Build Config → General
Product: Firefox → Firefox Build System
Target Milestone: Firefox 13 → mozilla13

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: