Closed
Bug 718431
Opened 12 years ago
Closed 12 years ago
WebConsole doesn't show the "warning" icons on warning and errors
Categories
(DevTools :: Console, defect, P2)
DevTools
Console
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 12
People
(Reporter: paul, Assigned: jwalker)
References
Details
(Keywords: regression)
Attachments
(1 file, 2 obsolete files)
4.85 KB,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Reporter | ||
Updated•12 years ago
|
Keywords: regression
Updated•12 years ago
|
Hardware: x86 → All
Assignee | ||
Comment 3•12 years ago
|
||
We're partially reverting the changes made here: https://hg.mozilla.org/mozilla-central/rev/8409adc46f14
Assignee | ||
Comment 4•12 years ago
|
||
Assignee | ||
Comment 5•12 years ago
|
||
swap !important for more specific rule
Attachment #591767 -
Attachment is obsolete: true
Attachment #591767 -
Flags: review?(paul)
Attachment #591769 -
Flags: review?(paul)
Assignee | ||
Updated•12 years ago
|
Attachment #591769 -
Flags: review?(dao)
Comment 6•12 years ago
|
||
Comment on attachment 591769 [details] [diff] [review] upload 2 >- " <li if=\"${command.params.length === 0}\">${l10n.helpManNone}</li>\n" + >- " <li foreach=\"param in ${command.params}\">\n" + >+ " <li if=\"${command.params.length === 0}\" class=\"gcliterm-li-plain\">${l10n.helpManNone}</li>\n" + >+ " <li foreach=\"param in ${command.params}\" class=\"gcliterm-li-plain\">\n" + Please find a class that describes the actual role of these nodes. >+li.gcliterm-li-plain { nit: drop the element name selector
Attachment #591769 -
Flags: review?(dao) → review-
Assignee | ||
Comment 7•12 years ago
|
||
(In reply to Dão Gottwald [:dao] from comment #6) > Comment on attachment 591769 [details] [diff] [review] > upload 2 > > >- " <li if=\"${command.params.length === 0}\">${l10n.helpManNone}</li>\n" + > >- " <li foreach=\"param in ${command.params}\">\n" + > >+ " <li if=\"${command.params.length === 0}\" class=\"gcliterm-li-plain\">${l10n.helpManNone}</li>\n" + > >+ " <li foreach=\"param in ${command.params}\" class=\"gcliterm-li-plain\">\n" + > > Please find a class that describes the actual role of these nodes. Unfortunately the purpose of the class is to reverse the effect a broad rule up the tree, so the role is to make an li plain. Do you have something else in mind? > >+li.gcliterm-li-plain { > > nit: drop the element name selector OK - It's not there by mistake, I wanted to make this rule clearly more specific than the broad rule that it's overriding, but I think we can take it out without changing how things work. Thanks.
Comment 8•12 years ago
|
||
I was referring to the role of the nodes, not the purpose of the class. E.g.: <ul class="gcli-help-parameter-list"> <li class="gcli-help-parameter"></li> <li class="gcli-help-parameter"></li> </ul>
Assignee | ||
Comment 9•12 years ago
|
||
(In reply to Dão Gottwald [:dao] from comment #8) > I was referring to the role of the nodes, not the purpose of the class. E.g.: > > <ul class="gcli-help-parameter-list"> > <li class="gcli-help-parameter"></li> > <li class="gcli-help-parameter"></li> > </ul> So are you saying that you would prefer that every time anyone uses an li inside GCLI, they have to create a new class, and all the classes say the same thing: "revert to default li styling"?
Comment 10•12 years ago
|
||
If you want this for any list item added in GCLI, just set list-style-image:none on .gcliterm-msg-body?
Assignee | ||
Comment 11•12 years ago
|
||
(In reply to Dão Gottwald [:dao] from comment #10) > If you want this for any list item added in GCLI, just set > list-style-image:none on .gcliterm-msg-body? Yes - good point, thanks. Done.
Attachment #591769 -
Attachment is obsolete: true
Attachment #591769 -
Flags: review?(paul)
Attachment #592094 -
Flags: review?(dao)
Updated•12 years ago
|
Attachment #592094 -
Flags: review?(dao) → review+
Assignee | ||
Comment 12•12 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=e6cb0ce0cbf3
Assignee | ||
Comment 13•12 years ago
|
||
Thanks Dão.
Assignee | ||
Comment 14•12 years ago
|
||
https://tbpl.mozilla.org/?tree=Fx-Team&rev=5e41076a67dd
Whiteboard: [fixed-in-fx-team]
Comment 15•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5e41076a67dd
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 12
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•