Closed
Bug 718440
Opened 12 years ago
Closed 12 years ago
Add more sampler labels to various places
Categories
(Core :: General, defect)
Tracking
()
RESOLVED
FIXED
mozilla12
People
(Reporter: jrmuizel, Assigned: jrmuizel)
Details
Attachments
(1 file, 3 obsolete files)
17.62 KB,
patch
|
BenWa
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #588899 -
Flags: review?
Assignee | ||
Comment 2•12 years ago
|
||
Attachment #588901 -
Flags: review?
Assignee | ||
Comment 3•12 years ago
|
||
Attachment #588903 -
Flags: review?
Assignee | ||
Updated•12 years ago
|
Attachment #588899 -
Flags: review? → review?(bgirard)
Assignee | ||
Updated•12 years ago
|
Attachment #588901 -
Flags: review? → review?(bgirard)
Assignee | ||
Updated•12 years ago
|
Attachment #588903 -
Flags: review? → review?(bgirard)
Comment 4•12 years ago
|
||
Comment on attachment 588903 [details] [diff] [review] Labels for debugging the github problem Review of attachment 588903 [details] [diff] [review]: ----------------------------------------------------------------- The patches looks good. It doesn't look like we're adding sampling to any performance critical code. I can r+ the cocoa changes but maybe we need someone else to review a patch that touch other modules. They just need to 'ok' adding a few cycles to these functions. ::: tools/profiler/sampler.h @@ +106,4 @@ > #define SAMPLER_GET_RESPONSIVENESS() NULL > #define SAMPLER_GET_FEATURES() NULL > #define SAMPLE_LABEL(name_space, info) > +#define SAMPLE_LABEL_FN(name_space, info) We should just pick a single standard and use it everywhere for all 3 patches. I think I would vote for that to be: SAMPLE_LABEL_FN The info parameter here isn't needed. Do you think PRETTY_FUNCTION is to verbose? Maybe using __func__ is enough. To be honest I think PRETTY_FUNCTION is too verbose because it include parameters and return type, and that __func__ is ambiguous because it doesn't include namespace.
Assignee | ||
Comment 5•12 years ago
|
||
This also gets rid of the function macros because they don't provide what we want. The naming is still pretty adhoc throughout as I'm not really sure what a good convention should be. I think we can figure that out as we add more labels and use them more.
Attachment #588899 -
Attachment is obsolete: true
Attachment #588901 -
Attachment is obsolete: true
Attachment #588903 -
Attachment is obsolete: true
Attachment #588899 -
Flags: review?(bgirard)
Attachment #588901 -
Flags: review?(bgirard)
Attachment #588903 -
Flags: review?(bgirard)
Attachment #589273 -
Flags: review?(bgirard)
Updated•12 years ago
|
Attachment #589273 -
Flags: review?(bgirard) → review+
Comment 6•12 years ago
|
||
Landed on inbound, but backed out: https://hg.mozilla.org/integration/mozilla-inbound/rev/88733ce1bef3 https://hg.mozilla.org/integration/mozilla-inbound/rev/ebc05c90d282 because of errors building nsLayoutModule.obj on Windows: https://tbpl.mozilla.org/php/getParsedLog.php?id=8618482&tree=Mozilla-Inbound
Assignee: nobody → jmuizelaar
Comment 7•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/88733ce1bef3 https://hg.mozilla.org/mozilla-central/rev/ebc05c90d282
Status: NEW → ASSIGNED
Comment 8•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/147c00d2ca3b Please comment in bugs when they land on inbound, especially if they've been backed out and/or re-landed. It takes some of the pain out of merging.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in
before you can comment on or make changes to this bug.
Description
•