Open Bug 718559 Opened 12 years ago Updated 2 years ago

UpdateEditableState is expensive during subtree appends

Categories

(Core :: DOM: Core & HTML, defect, P5)

x86
macOS
defect

Tracking

()

People

(Reporter: bzbarsky, Unassigned)

References

Details

(Keywords: perf)

When appending large subtrees, the UpdateEditableState calls we do on each node are pretty expensive.  In my profiling, they're about 17% of the cost of the append.  The testcases in bug 700981 show it pretty nicely.  This is on gcc-4.2, though.

The issue is that we have to do a virtual call, land in nsGenericHTMLElement::UpdateEditableState, have to call up to nsGenericElement::UpdateEditableState, etc.  Most of the cost is the various function call overhead.  Not sure what we can do here; ideally we'd get to the point where we can effectively inline UpdateEditableState at compile time into nsGenericElement::BindToTree...
Blocks: 700981
Keywords: perf
https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven’t been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.
Priority: -- → P5
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.