71871 - hierarchical history should group by day, not by age

Status: VERIFIED FIXED

(Core Graveyard :: History: Global, defect, P3)

Description

[Alec Flett]

right now, the entries for "Today", "Yesterday" and so forth are grouped by age
- i.e. "Today" is all sites visited in the last 24 hours. 

Instead, we should be actually showing sites listed today (i.e. since midnight
of the previous night) and so forth. This basically involves changing the way we
calculate the age in days...really simple fix, and involves some minor code
cleanup too..patch forthcoming

Comment 1

[Alec Flett]

my patch is blossoming into a fix for another bug. I'll file that one too...

Comment 2

[Alec Flett]

Attachment: fix, plus find notification stuff

Comment 3

[Alec Flett]

that patch fixes this bug as well as bug 66907 (history doesn't update as you surf)

basically I did a few things:
- made a generic GetAgeInDays() which does local-time normalization, and used
that when calculating AgeInDays

The other stuff that's going on:
- added a bunch of extra notifications when you update a page in history.
- moved GetFindUriPrefix out to nsGlobalHistory so I could generate FindUris
from searchQueries easily.. also had to tweak it a bit so that I could still
cache a find uri prefix in the SearchEnumerator, and added an extra parameter so
that I could generate finduris that had a "groupby=<colname>" parameter.
- moved the search enumerator's RowMatches() function out to nsGlobalHistory, so
I could short-circuit HasAssertion, so I could avoid creating SearchEnumerators
every time I did a notification (speeds up the notifications when doing a
HasAssertion(find:<uri> --#child--> <url>) query

adding waterson for sr=, looking around for an r=

Comment 4

[Alec Flett]

adding shaver for a review

Comment 5

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

r=shaver.  I'm never reviewing for you again.

Comment 6

[Alec Flett]

hee hee. That's one. Now I just need another suck^H^H^H^Hreviewer

Comment 7

[Alec Flett]

fix is in.

Comment 8

[sairuh (rarely reading bugmail)]

mass-verifying claudius' Fixed bugs which haven't changed since 2001.12.31.

if you think this particular bug is not fixed, please make sure of the following
before reopening:

a. retest with a *recent* trunk build.
b. query bugzilla to see if there's an existing, open bug (new, reopened,
assigned) that covers your issue.
c. if this does need to be reopened, make sure there are specific steps to
reproduce (unless already provided and up-to-date).

thanks!

[set your search string in mail to "AmbassadorKoshNaranek" to filter out these
messages.]