Closed
Bug 718861
Opened 12 years ago
Closed 12 years ago
Add required fields to Step 3
Categories
(addons.mozilla.org Graveyard :: Developer Pages, defect, P1)
addons.mozilla.org Graveyard
Developer Pages
Tracking
(Not tracked)
RESOLVED
FIXED
6.4.2
People
(Reporter: clouserw, Assigned: spasovski)
References
Details
Step 3 has us confirming the name, summary, and description. There are a few more fields we can take from the add-ons site. Added to this page should be: - Homepage (default: blank) - Support Information. Let's make this only the Website field for now as the mockups we've seen don't have a place for email. One new field (it doesn't exist for add-ons yet) is form factor compatibility. Add this to the bottom as checkboxes. The three options will be mobile, tablet, and desktop. We should have pretty icons and detailed mouse-over help and I'll CC some people who can help with that.
Updated•12 years ago
|
Assignee: nobody → cvan
Target Milestone: --- → 6.3.9
Reporter | ||
Updated•12 years ago
|
Target Milestone: 6.3.9 → 6.4.0
Reporter | ||
Comment 2•12 years ago
|
||
Done by EOD but bumping to current milestone
Target Milestone: 6.4.0 → 6.4.1
Reporter | ||
Updated•12 years ago
|
Target Milestone: 6.4.1 → 6.4.2
Assignee | ||
Comment 3•12 years ago
|
||
Here is the implementation for this: https://github.com/spasovski/zamboni/commit/0d1914d The form tests are complete and pass, the edit app tests are written and pass, the submit app - step 3 (describe) needs a required field test. As in 'device_form' should `self.assertFormError(r, 'device_form', 'device_types', 'This field is required.')`
Target Milestone: 6.4.2 → 6.4.1
Assignee | ||
Updated•12 years ago
|
Target Milestone: 6.4.1 → 6.4.2
Assignee | ||
Comment 4•12 years ago
|
||
done: https://github.com/mozilla/zamboni/commit/3a2299c
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 5•12 years ago
|
||
I see this traceback on -dev: Traceback (most recent call last): File "/data/www/apps-preview-dev.allizom.org/zamboni/vendor/src/django/django/core/handlers/base.py", line 111, in get_response response = callback(request, *callback_args, **callback_kwargs) File "/data/www/apps-preview-dev.allizom.org/zamboni/apps/addons/decorators.py", line 29, in wrapper return f(request, addon, *args, **kw) File "/data/www/apps-preview-dev.allizom.org/zamboni/apps/addons/views.py", line 92, in addon_detail return extension_detail(request, addon) File "/data/www/apps-preview-dev.allizom.org/zamboni/vendor/src/django-mobility/mobility/decorators.py", line 49, in wrapper return normal_fn(request, *args, **kw) File "/data/www/apps-preview-dev.allizom.org/zamboni/vendor/src/django/django/views/decorators/vary.py", line 19, in inner_func response = func(*args, **kwargs) File "/data/www/apps-preview-dev.allizom.org/zamboni/apps/addons/views.py", line 157, in extension_detail return jingo.render(request, 'addons/impala/details-more.html', ctx) File "/data/www/apps-preview-dev.allizom.org/zamboni/vendor/src/jingo/jingo/__init__.py", line 80, in render rendered = render_to_string(request, template, context) File "/data/www/apps-preview-dev.allizom.org/zamboni/vendor/src/jingo/jingo/__init__.py", line 98, in render_to_string return template.render(**get_context()) File "/usr/lib64/python2.6/site-packages/jinja2/environment.py", line 891, in render return self.environment.handle_exception(exc_info, True) File "/data/www/apps-preview-dev.allizom.org/zamboni/apps/addons/templates/addons/impala/details-more.html", line 33, in top-level template code {% cache addon %} File "/data/www/apps-preview-dev.allizom.org/zamboni/apps/amo/ext.py", line 18, in _cache_support return caller() File "/data/www/apps-preview-dev.allizom.org/zamboni/apps/addons/templates/addons/impala/details-more.html", line 53, in template {% set device_types = addon.device_types %} File "/usr/lib64/python2.6/site-packages/jinja2/environment.py", line 371, in getattr return getattr(obj, attribute) File "/data/www/apps-preview-dev.allizom.org/zamboni/apps/webapps/models.py", line 109, in device_types return [d.device_type for d in self.addondevicetype_set.all()] File "/data/www/apps-preview-dev.allizom.org/zamboni/vendor/src/django/django/db/models/query.py", line 107, in _result_iter self._fill_cache() File "/data/www/apps-preview-dev.allizom.org/zamboni/vendor/src/django/django/db/models/query.py", line 784, in _fill_cache self._result_cache.append(self._iter.next()) File "/data/www/apps-preview-dev.allizom.org/zamboni/vendor/src/django-cache-machine/caching/base.py", line 102, in __iter__ obj = iterator.next() File "/data/www/apps-preview-dev.allizom.org/zamboni/vendor/src/django-cache-machine/caching/base.py", line 158, in fetch_by_id pks = [val[0] for val in vals] File "/data/www/apps-preview-dev.allizom.org/zamboni/vendor/src/django/django/db/models/query.py", line 107, in _result_iter self._fill_cache() File "/data/www/apps-preview-dev.allizom.org/zamboni/vendor/src/django/django/db/models/query.py", line 784, in _fill_cache self._result_cache.append(self._iter.next()) File "/data/www/apps-preview-dev.allizom.org/zamboni/vendor/src/django/django/db/models/query.py", line 971, in iterator for row in self.query.get_compiler(self.db).results_iter(): File "/data/www/apps-preview-dev.allizom.org/zamboni/vendor/src/django/django/db/models/sql/compiler.py", line 695, in results_iter for rows in self.execute_sql(MULTI): File "/data/www/apps-preview-dev.allizom.org/zamboni/vendor/src/django/django/db/models/sql/compiler.py", line 750, in execute_sql cursor.execute(sql, params) File "/data/www/apps-preview-dev.allizom.org/zamboni/vendor/src/django/django/db/backends/mysql/base.py", line 86, in execute return self.cursor.execute(query, args) File "/usr/lib64/python2.6/site-packages/MySQLdb/cursors.py", line 173, in execute self.errorhandler(self, exc, value) File "/usr/lib64/python2.6/site-packages/MySQLdb/connections.py", line 36, in defaulterrorhandler raise errorclass, errorvalue DatabaseError: (1146, "Table 'appspreviewdev_allizom_org.addons_devicetypes' doesn't exist")
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 6•12 years ago
|
||
Has the fixed update script fixed this?
Comment 7•12 years ago
|
||
It looks like we're good now.
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
Comment 8•12 years ago
|
||
Actually I take that back. Still a traceback. This looks like a botched migration.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 9•12 years ago
|
||
I'll take a look also
Assignee | ||
Updated•12 years ago
|
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
Updated•8 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•