Closed
Bug 718897
Opened 12 years ago
Closed 12 years ago
add get_light to lights.h and liblights.cpp
Categories
(Core :: Hardware Abstraction Layer (HAL), defect)
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: jstraus, Assigned: jstraus)
Details
Attachments
(2 files)
848 bytes,
patch
|
Details | Diff | Splinter Review | |
3.65 KB,
patch
|
Details | Diff | Splinter Review |
liblights doesn't currently provide and abstract way to get the state of the lights to correspond to get_lights. This bug adds that functionality.
Assignee | ||
Comment 1•12 years ago
|
||
This would require our partners to enhance their libhardware to support the extended functionality. If it is accepted, revisit bug 712378 and define HAVEGETLIGHT.
Assignee | ||
Comment 2•12 years ago
|
||
Assignee: nobody → jstraus
Attachment #589367 -
Flags: review?
Assignee | ||
Comment 3•12 years ago
|
||
Attachment #589369 -
Flags: review?
Updated•12 years ago
|
Attachment #589367 -
Flags: review? → review?(justin.lebar+bug)
Updated•12 years ago
|
Attachment #589369 -
Flags: review? → review?(justin.lebar+bug)
Comment 4•12 years ago
|
||
This patch didn't have a specific reviewer tagged; looking at other patches in this component justin.lebar+bug@gmail.com seems a common review (along with cjones?). Feel free to reassign review as needed.
Comment 5•12 years ago
|
||
> This would require our partners to enhance their libhardware to support the extended
> functionality.
Specifically, assuming HAVEGETLIGHT would require that our partners enhance their libraries, right?
I don't think I'm the right reviewer here for this Linux-y stuff.
Updated•12 years ago
|
Attachment #589367 -
Flags: review?(justin.lebar+bug) → review?(mwu)
Updated•12 years ago
|
Attachment #589369 -
Flags: review?(justin.lebar+bug) → review?(mwu)
Comment 6•12 years ago
|
||
I don't see the point. Why not just cache the last value set for the light? We support a number of devices right now and modifying all of them to support this API seems unnecessary extra work. This also makes it more difficult to support devices where we don't have access to the source of the lights module.
Comment 7•12 years ago
|
||
> Why not just cache the last value set for the light? AIUI that's what we do now in bug 712378.
Comment 8•12 years ago
|
||
(In reply to Justin Lebar [:jlebar] from comment #7) > > Why not just cache the last value set for the light? > > AIUI that's what we do now in bug 712378. Great. No need for this then.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → WONTFIX
Updated•12 years ago
|
Attachment #589367 -
Flags: review?(mwu)
Updated•12 years ago
|
Attachment #589369 -
Flags: review?(mwu)
You need to log in
before you can comment on or make changes to this bug.
Description
•