Closed Bug 718961 Opened 12 years ago Closed 12 years ago

History-visited link color

Categories

(Firefox for Android Graveyard :: General, defect, P1)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
ARM
Android
Type:
defect

Tracking

(firefox11 fixed, firefox12 fixed, firefox13 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 12
Tracking Flags:
Tracking Status
firefox11 --- fixed
firefox12 --- fixed
firefox13 --- verified

People

(Reporter: carla.nadastean, Assigned: kats)

References

Details

(Keywords: regression)

Attachments

(2 files)

(1/2) Copy URI into native object wrapper
921 bytes, patch
blassey
: review+
akeybl
: approval-mozilla-aurora+
Details | Diff | Splinter Review
(2/2) Fix typo
2.45 KB, patch
blassey
: review+
akeybl
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
Nightly: Fennec/12.0a1(2012-01-17)
HTC Desire Z (Android 2.3)

Steps to reproduce:
   1. Go to news.google.com or any other page with links
   2. Chose a link that was not visited before
   3. Open it in new tab or tap on it and then go back to the initial page

Expected Result:
The link color is blue and after the visit it changes into purple.

Actual Result:
The visited link color doesn't change after the link was visited.

NOTE:This could be regression from bug 695170.
status-firefox11: --- → unaffected
status-firefox12: --- → affected
Kats, sounds like we regressed
Assignee: nobody → bugmail.mozilla
Priority: -- → P1
Attached patch (2/2) Fix typo — — Splinter Review 

        Attachment #590905 -
        Flags: review?(blassey.bugs)

    
    

    
  
Regression was introduced in bdabac538e90, which was landed in aurora as bd6bcca22234. So this probably affects aurora as well.
Keywords: regression

    
    

    
  
Yes, Aurora has regressed too.
Blocks: 715507
tracking-fennec: --- → ?

          status-firefox11:
          unaffected → affected

        Attachment #590904 -
        Flags: review?(blassey.bugs) → review+

        Attachment #590905 -
        Flags: review?(blassey.bugs) → review+

    
    

    
  
Comment on attachment 590904 [details] [diff] [review]
(1/2) Copy URI into native object wrapper

[Approval Request Comment]
Regression caused by (bug #): 715507
User impact if declined: visited links don't get coloured
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): mobile-only, low-risk

        Attachment #590904 -
        Flags: approval-mozilla-aurora?

        Attachment #590905 -
        Flags: approval-mozilla-aurora?

    
    

    
  
Comment on attachment 590904 [details] [diff] [review]
(1/2) Copy URI into native object wrapper

[Triage Comment]
Mobile only - approved for Aurora.

        Attachment #590904 -
        Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

    
  

        Attachment #590905 -
        Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

    
    

    
  
Verified fixed on:

Firefox 13.0a1 (2012-03-02)
20120302031112
http://hg.mozilla.org/mozilla-central/rev/3a7b9e61c263

--
Device: Samsung Galaxy S2
OS: Android 2.3.4
Status: RESOLVED → VERIFIED

          status-firefox13:
          --- → verified
tracking-fennec: ? → ---
Product: Firefox for Android → Firefox for Android Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: